Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FM v0.6.0]--Support log rotation policy #171

Merged
merged 4 commits into from
Sep 23, 2022
Merged

[FM v0.6.0]--Support log rotation policy #171

merged 4 commits into from
Sep 23, 2022

Conversation

Huanli-Meng
Copy link
Contributor

Motivations

Function Mesh v0.6.0 support setting log rotation policies (code PR#463), therefore add docs accordingly.

Modifications

  • Update Functions/Sources/Sinks CRD configurations doc
  • Add a new section "Set log rotation policies" in the "Produce function logs" document

@Huanli-Meng Huanli-Meng requested review from tuteng and a team as code owners September 19, 2022 07:56
@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for function-mesh ready!

Name Link
🔨 Latest commit 5dfbff0
🔍 Latest deploy log https://app.netlify.com/sites/function-mesh/deploys/632c113c5343c70009984f79
😎 Deploy Preview https://deploy-preview-171--function-mesh.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Huanli-Meng Huanli-Meng changed the title [WIP][FM v0.6.0]--Support log rotation policy [FM v0.6.0]--Support log rotation policy Sep 19, 2022
teachwrite
teachwrite previously approved these changes Sep 19, 2022
Copy link
Contributor

@teachwrite teachwrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Huanli-Meng Huanli-Meng self-assigned this Sep 21, 2022
@Huanli-Meng
Copy link
Contributor Author

@tpiperatgod I've applied the technical and editorial review comments. Could you please help look into it again and feel free to approve it if there are no more comments? Thanks.

@Huanli-Meng Huanli-Meng merged commit cceaebe into main Sep 23, 2022
@Huanli-Meng Huanli-Meng deleted the log-rotation branch September 23, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants