-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FM v0.6.0]--Support log rotation policy #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for function-mesh ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Huanli-Meng
changed the title
[WIP][FM v0.6.0]--Support log rotation policy
[FM v0.6.0]--Support log rotation policy
Sep 19, 2022
teachwrite
previously approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tpiperatgod
reviewed
Sep 21, 2022
Huanli-Meng
force-pushed
the
log-rotation
branch
from
September 22, 2022 07:33
fe3c337
to
df39542
Compare
@tpiperatgod I've applied the technical and editorial review comments. Could you please help look into it again and feel free to approve it if there are no more comments? Thanks. |
tpiperatgod
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Function Mesh v0.6.0 support setting log rotation policies (code PR#463), therefore add docs accordingly.
Modifications