Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support log rotation #463

Merged
merged 7 commits into from
Sep 12, 2022
Merged

support log rotation #463

merged 7 commits into from
Sep 12, 2022

Conversation

tpiperatgod
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #461

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

  • Add support for Java runtime log rotation
  • Add support for Python runtime log rotation

Available rotation policies:

  • TimedPolicyWithDaily
  • TimedPolicyWithWeekly
  • TimedPolicyWithMonthly
  • SizedPolicyWith10MB
  • SizedPolicyWith50MB
  • SizedPolicyWith100MB

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
@tpiperatgod tpiperatgod requested review from nlu90, freeznet and a team as code owners September 6, 2022 03:28
@github-actions github-actions bot added the doc-required This pr needs a document label Sep 6, 2022
Signed-off-by: laminar <tpiperatgod@gmail.com>
@tpiperatgod tpiperatgod changed the title support log rotation [WIP] support log rotation Sep 6, 2022
Signed-off-by: laminar <tpiperatgod@gmail.com>
@tpiperatgod tpiperatgod changed the title [WIP] support log rotation support log rotation Sep 6, 2022
@tpiperatgod
Copy link
Contributor Author

For Golang runtime functions, we need to get the pulsar-function-go project to support log rotation first.

@nlu90 nlu90 merged commit d4d9b7c into streamnative:master Sep 12, 2022
@Huanli-Meng Huanli-Meng added doc-added and removed doc-required This pr needs a document labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants