Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support k8s 1.18+ with backward compatibility #116

Closed
freeznet opened this issue Apr 14, 2021 · 4 comments
Closed

support k8s 1.18+ with backward compatibility #116

freeznet opened this issue Apr 14, 2021 · 4 comments
Assignees

Comments

@freeznet
Copy link
Member

kubectl apply -f cloud.streamnative.io_functions.yaml will cause following error, which will break the CI tests of function mesh java proxy.

The CustomResourceDefinition "functions.cloud.streamnative.io" is invalid: 
* spec.validation.openAPIV3Schema.properties[spec].properties[pod].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[spec].properties[pod].properties[sidecars].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
@freeznet freeznet self-assigned this Apr 14, 2021
@freeznet
Copy link
Member Author

As a result of: kubernetes/kubernetes#88076 that is included in k8s 1.18 (https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#other-api-changes) keys have to be either required or have a default value.

freeznet added a commit that referenced this issue Apr 14, 2021
@freeznet
Copy link
Member Author

freeznet commented Apr 14, 2021

#104 fixes the ci tests issue with align k8s version to 1.15, but the CRD is still not working with 1.18+, will look into it later.

@freeznet freeznet changed the title manifests from kubebuilder is not work with k8s 1.18 support k8s 1.18 with backward compatibility Apr 16, 2021
@freeznet freeznet changed the title support k8s 1.18 with backward compatibility support k8s 1.18+ with backward compatibility Apr 16, 2021
@freeznet freeznet reopened this Apr 16, 2021
@freeznet
Copy link
Member Author

update the API version to v1

@freeznet
Copy link
Member Author

fixed by #328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant