Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 315] Move apiextensions.k8s.io/v1beta1 to apiextensions.k8s.io/v1 #328

Merged
merged 7 commits into from
Mar 8, 2022

Conversation

hantmac
Copy link
Contributor

@hantmac hantmac commented Feb 25, 2022

Signed-off-by: hantmac hantmac@outlook.com

  • Move apiextensions.k8s.io/v1beta1 to apiextensions.k8s.io/v1
  • fix Issue 315

@hantmac hantmac force-pushed the fix/apiextensions-version branch from 68049fa to f41b268 Compare February 25, 2022 06:13
@freeznet freeznet added component/controller type/enhancement Indicates an improvement to an existing feature labels Feb 28, 2022
@hantmac
Copy link
Contributor Author

hantmac commented Feb 28, 2022

We need to use kubectl conver to convert the apiextensions.k8s.io/v1 to apiextensions.k8s.io/v1beta1 in function-mesh/config/crd/patches, but the kube version in my machine can't do this beacause I don't have the lower version.

image

So can you do the kubectl convert ?

@freeznet
Copy link
Member

@hantmac I have tried with the convert plugin, seems we need to use a lower version's kubectl and related client release to do this. lets try use the kubectl image like https://hub.docker.com/r/bitnami/kubectl

Signed-off-by: hantmac <hantmac@outlook.com>
@hantmac hantmac force-pushed the fix/apiextensions-version branch from 1f88172 to 03739f3 Compare March 1, 2022 02:10
@hantmac
Copy link
Contributor Author

hantmac commented Mar 1, 2022

@hantmac I have tried with the convert plugin, seems we need to use a lower version's kubectl and related client release to do this. lets try use the kubectl image like https://hub.docker.com/r/bitnami/kubectl

Yes, I have done this convert. But we need to modify the k8s version in github ci, wait for me.

@hantmac
Copy link
Contributor Author

hantmac commented Mar 1, 2022

@freeznet I guess the helm chart of local-storage-provisioner is not newest, the version of DaemonSet in it is extensions/v1beta1, I have made this issue

@freeznet
Copy link
Member

freeznet commented Mar 3, 2022

thanks @hantmac, from my experience, the local-storage-provisioner might not a MUST have service in the test environment, so maybe we can simplifier the Github Action script to make the Pulsar install minimal (see #331)

@hantmac
Copy link
Contributor Author

hantmac commented Mar 4, 2022

@freeznet Copy that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/controller doc-added type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move apiextensions.k8s.io/v1beta1 to apiextensions.k8s.io/v1
4 participants