Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1.8.2 for cert-manager tests #433

Conversation

jiangpengcheng
Copy link
Member

Motivation

the latest cert-manager(v1.9.0) chart is not compatible with k8s=v1.8.20

ERROR commands: [helm repo add jetstack [https://charts.jetstack.io\nhelm](https://charts.jetstack.io/nhelm) repo update\nhelm install cert-manager jetstack/cert-manager --set installCRDs=true\n] runs error: Error: INSTALLATION FAILED: chart requires kubeVersion: >= 1.19.0-0 which is incompatible with Kubernetes v1.18.20

Modifications

Use cert-manager v1.8.2 in tests environment

Verifying this change

  • Make sure that the change passes the CI checks.

  • This change is a trivial rework / code cleanup without any test coverage.

Documentation

Check the box below.

Need to update docs?

  • no-need-doc

    Fix tests

@jiangpengcheng jiangpengcheng requested review from nlu90, freeznet and a team as code owners July 24, 2022 23:54
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jul 24, 2022
Copy link
Contributor

@tpiperatgod tpiperatgod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiangpengcheng
Copy link
Member Author

lgtm and here also needs to be updated: https://github.com/streamnative/function-mesh/blob/master/.ci/tests/integration/e2e.yaml#L20

it's already updated

@jiangpengcheng jiangpengcheng merged commit bc6081c into streamnative:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants