Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine test cases of the Sink/Source/Crypto function #435

Merged
merged 4 commits into from
Aug 2, 2022
Merged

refine test cases of the Sink/Source/Crypto function #435

merged 4 commits into from
Aug 2, 2022

Conversation

tpiperatgod
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #425

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Refine test cases of the Sink/Source/Crypto function

Modifications

  • adjust Sink e2e test case
  • adjust Source e2e test case
  • adjust Crypto function e2e test case

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@tpiperatgod tpiperatgod requested review from nlu90, freeznet and a team as code owners July 25, 2022 12:56
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jul 25, 2022
@tpiperatgod
Copy link
Contributor Author

prefer to review this PR after #433 is merged.

Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
@jiangpengcheng jiangpengcheng merged commit 91b8f16 into streamnative:master Aug 2, 2022
@tpiperatgod tpiperatgod deleted the issue+425 branch August 2, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m/2022-08 no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine the test cases of Sink\Source\Crypto function
4 participants