Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

[FEATURE] Kop needs to support the v0 version of SASL_HANDSHAKE #667

Closed
wenbingshen opened this issue Aug 20, 2021 · 1 comment · Fixed by #676
Closed

[FEATURE] Kop needs to support the v0 version of SASL_HANDSHAKE #667

wenbingshen opened this issue Aug 20, 2021 · 1 comment · Fixed by #676
Assignees
@wenbingshen
Labels
type/feature Indicates new functionality

Comments

@wenbingshen
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If SaslHandshakeRequest version is v0, a series of SASL client and server tokens corresponding to the mechanism are sent as opaque packets without wrapping the messages with Kafka protocol headers. However, KoP always parses the header before a request is processed.

Describe the solution you'd like
We need support sasl tokens are sent without Kafka SaslAuthenticate request/responses.

This feature belongs to the compatibility issue of the old version of kafka with kop.
@wenbingshen wenbingshen added the type/feature Indicates new functionality label Aug 20, 2021
@wenbingshen
Copy link
Contributor Author

@BewareMyPower I want to try to work on this feature, can you assign it to me first? Thanks.

@wenbingshen wenbingshen mentioned this issue Aug 24, 2021
Merged
BewareMyPower pushed a commit that referenced this issue Aug 27, 2021
@wenbingshen
[FEATURE] Support kop for v0 version of SASL_HANDSHAKE (#676)
2b4f545 
Fixes #667 

### Motivation
If SaslHandshakeRequest version is v0, a series of SASL client and server tokens corresponding to the mechanism are sent as opaque packets without wrapping the messages with Kafka protocol headers. However, KoP always parses the header before a request is processed.

### Modifications
Support sasl/plain tokens are sent without Kafka SaslAuthenticate request/responses and compatible with existing authenticate.
BewareMyPower pushed a commit that referenced this issue Aug 30, 2021
@wenbingshen @BewareMyPower
[FEATURE] Support kop for v0 version of SASL_HANDSHAKE (#676)
f115ea0 
Fixes #667 

### Motivation
If SaslHandshakeRequest version is v0, a series of SASL client and server tokens corresponding to the mechanism are sent as opaque packets without wrapping the messages with Kafka protocol headers. However, KoP always parses the header before a request is processed.

### Modifications
Support sasl/plain tokens are sent without Kafka SaslAuthenticate request/responses and compatible with existing authenticate.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wenbingshen wenbingshen

Labels
type/feature Indicates new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEATURE] Support kop for v0 version of SASL_HANDSHAKE wenbingshen/kop
1 participant
@wenbingshen