This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[FEATURE] Support kop for v0 version of SASL_HANDSHAKE #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BewareMyPower This pr is ready for review, PTAL :) |
wenbingshen
changed the title
wenbingshen
commented
Aug 25, 2021
...a/io/streamnative/pulsar/handlers/kop/compatibility/saslplain/SaslPlainEndToEndTestBase.java
Show resolved
Hide resolved
...a/io/streamnative/pulsar/handlers/kop/compatibility/saslplain/SaslPlainEndToEndTestBase.java
Show resolved
Hide resolved
...a/io/streamnative/pulsar/handlers/kop/compatibility/saslplain/SaslPlainEndToEndTestBase.java
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/security/SaslAuthenticator.java
Outdated
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/security/SaslAuthenticator.java
Outdated
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaCommandDecoder.java
Outdated
Show resolved
Hide resolved
|
Could you add the comments into the source code? |
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaCommandDecoder.java
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/security/SaslAuthenticator.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Aug 26, 2021
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/security/SaslAuthenticator.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Aug 26, 2021
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaCommandDecoder.java
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaCommandDecoder.java
Outdated
Show resolved
Hide resolved
|
@BewareMyPower I updated the code, PTAL |
...a/io/streamnative/pulsar/handlers/kop/compatibility/saslplain/SaslPlainEndToEndTestBase.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Aug 27, 2021
...a/io/streamnative/pulsar/handlers/kop/compatibility/saslplain/SaslPlainEndToEndTestBase.java
Outdated
Show resolved
Hide resolved
BewareMyPower
approved these changes
Aug 27, 2021
|
@BewareMyPower Thanks for your patience review. :) |
BewareMyPower
pushed a commit
that referenced
this pull request
Aug 30, 2021
Fixes #667 ### Motivation If SaslHandshakeRequest version is v0, a series of SASL client and server tokens corresponding to the mechanism are sent as opaque packets without wrapping the messages with Kafka protocol headers. However, KoP always parses the header before a request is processed. ### Modifications Support sasl/plain tokens are sent without Kafka SaslAuthenticate request/responses and compatible with existing authenticate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #667
Motivation
If SaslHandshakeRequest version is v0, a series of SASL client and server tokens corresponding to the mechanism are sent as opaque packets without wrapping the messages with Kafka protocol headers. However, KoP always parses the header before a request is processed.
Modifications
Support sasl/plain tokens are sent without Kafka SaslAuthenticate request/responses and compatible with existing authenticate.