Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quest to make surface=paved/unpaved more detailed #279

Closed
matkoniecz opened this issue Jun 1, 2017 · 11 comments · Fixed by #2078
Closed

add quest to make surface=paved/unpaved more detailed #279

matkoniecz opened this issue Jun 1, 2017 · 11 comments · Fixed by #2078
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Comments

@matkoniecz
Copy link
Member

matkoniecz commented Jun 1, 2017

Currently surface quest for detailed surface info, but there is no quest to make general surface values more clear.

And there is significant difference between surface=cobblestone and surface=asphalt, surface=grass_paver or surface=compacted (especially for cases like people on wheelchairs or cyclists).

I propose to add similar quests, asked for surface=paved and surface=unpaved and asking to make these data more detailed - it will allow both to make existing data more detailed and stop discouraging answering general answer.

For example I just cycled several streets, all paved. I would solve these quests as I am now waiting in queue - but as I am not remembering which part was surface=paving_stones and answering surface=paved would hide theses quests I decided to not do anything.


query: exclude ways with cycleway:surface, surface:cycleway, footway:surface, surface:footway, segregated=yes

@CloCkWeRX
Copy link

CloCkWeRX commented Jun 2, 2017

Maybe a quest for https://wiki.openstreetmap.org/wiki/Key:smoothness on surface=unpaved might better target the "how well can I travel on this with a bike/wheelchair/etc" - see also #133

@matkoniecz
Copy link
Member Author

smoothness key is tricky and a separate issue so any discussion should happen in a separate issu/ticket/feature request.

@matkoniecz
Copy link
Member Author

Response to @westnordost in #322 (here, as it is relevant to this proposal)

But what to do in the case the user can (rightfully) really not say what kind of public building it is? (ie its some weird mixture?) This is the same reason why surface=unpaved etc exists.

I never encountered case where it was impossible to use something more detailed that surface=unpaved. Sometimes road splitting was necessary and some generalization may be necessary, but so far I never encountered situation where it is impossible.

for example for http://www.openstreetmap.org/way/297445670#map=18/49.41306/21.98244 I ended using surface=compacted though I was tempted to use something like surface=asphalt;earth;sand;gravel;grass or surface=very_old_asphalt_mostly_completely_crushed_with_grass_and_earth_peaking_through_with_some_potholes_filled_with_earth.

matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 14, 2017
matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 14, 2017
matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 14, 2017
matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 14, 2017
matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 14, 2017
matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 14, 2017
matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 14, 2017
matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 14, 2017
@westnordost
Copy link
Member

westnordost commented Jun 14, 2017

I do not agree.

The case you mention is exactly the case I have in mind when I think about when surface=paved (or unpaved, ground) is the right thing to choose. If it is very old crumbling asphalt, compacted is also wrong because it is simply not a compacted road. It may not be asphalt anymore either, so this is where the "generic" categories come in. It is easier to say "well it is more or less not paved generally" than "well it is more or less a gravel road".
(More so with surface=unpaved and surface=ground roads by the way.)

I see the point of this quest: There are many many tags with surface=paved of which most will probably be asphalt etc., so it is good to offer users to answer it in more detail.
But how to do this? There are simply also those cases where the surface cannot be determined any more detailed. Those that have been added in the past and those that are added even now with StreetComplete.

Apart from the "asking again once" part of this, which is just a nuisance, the bigger issue here is that it should be a valid answer to say "yes, it cannot be determined in more detail than simply 'paved'" and this answer should be persistent, as in that StreetComplete does not ask the next guy the same question. See #322 (comment) .

There are different ways to do that, my suggestion is to require the user to add a short comment that should describe the surface of the road and add this comment in surface:note. The "detail surface quest" is then not shown for any roads that have this tag.

@matkoniecz
Copy link
Member Author

Note that in this case generic surface=paved would not be correct. It was not merely "very old asphalt with cracks". The asphalt was so degraded that it was not even obvious that road used to be asphalt road in the past. It was closer to surface=unpaved than surface=paved.

Asphalt was completely crushed (except very small patches), mixed with gravel substructure and sand/gravel/earth.

I am pretty convinced that it was fitting

A mixture of larger (e.g., gravel) and smaller (e.g., sand) parts, compacted (e.g., with a roller), so the surface is more stable than loose gravel.

definition.

@matkoniecz
Copy link
Member Author

There are different ways to do that, my suggestion is to require the user to add a short comment that should describe the surface of the road and add this comment in surface:note. The "detail surface quest" is then not shown for any roads that have this tag.

That would be a good solution.

@westnordost
Copy link
Member

The description in the "describe road surface" dialog needs to be shorter than 256 characters by the way, it would be good to have a small counter in that dialog which reveals itself and counts down for the last X characters the user may type.
This is a hard limit imposed by the OSM database.

matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 15, 2017
matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 16, 2017
matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 16, 2017
@westnordost westnordost added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Jun 30, 2017
@areynoua
Copy link

areynoua commented Aug 2, 2019

For my use of the app, I would like to be able to activate and deactivate a "surface" quest for roads labeled with a general value (paved, unpaved, earth...). It should be a quest disabled by default, but that you could activate when you know it's useful (a quick look at overpassturbo shows me that it would be convenient around my house).

@matkoniecz
Copy link
Member Author

One more question-before-implementation to @westnordost : would it be OK to ask about all kinds of surface=paved/unpaved? With roads, paths and all other objects within one quest?

Or would it be required to limit it to the same features as road quest and path quest and keep it split into two quests?

Or limit it to highway=* but have questions for roads and paths, footways, cycleways in one quest without splitting it into two quests? I think this one is my favorite.


@areynoua

earth

This is not a general value, it is a synonym of surface=dirt

@westnordost
Copy link
Member

No, it should be two quests because the user might want to select only the category of quests that he is interested in. Perhaps he is only interested in streets. I'd say the information on roads is also more important than on paths and often easier to answer.

@xuiqzy
Copy link
Contributor

xuiqzy commented Apr 6, 2020

It would also be nice to keep the information that the surface cannot be determined in more detail machine-readable as all the note:*=* keys are not and should not be machine readable by design.

Something roughly like surface:detail_available=no in addition to the actual description of the situation in the surface:note key would achieve that in a similar fashion to the machine readable opening_hours:signed=no for example.

matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
5 participants