Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacement for amenity=public_building #322

Closed
matkoniecz opened this issue Jun 13, 2017 · 8 comments
Closed

replacement for amenity=public_building #322

matkoniecz opened this issue Jun 13, 2017 · 8 comments

Comments

@matkoniecz
Copy link
Member

matkoniecz commented Jun 13, 2017

This nonspecific tag would benefit from replacing it with more precise one

https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dpublic_building mentions

  • office=government for government offices
  • amenity=townhall
  • amenity=library
  • amenity=police
  • amenity=hospital
  • amenity=school
  • leisure=sports_centre
  • amenity=community_centre

It seems that also following may be useful:

  • office=yes
@westnordost
Copy link
Member

westnordost commented Jun 13, 2017 via email

@matkoniecz
Copy link
Member Author

can (rightfully) really not say what kind of public building it is

I would expect it to be so rare that it would fall under "can't say, hide quest". I can implement it in my personal fork and test it.

@westnordost
Copy link
Member

westnordost commented Jun 14, 2017 via email

@matkoniecz
Copy link
Member Author

In that case coffeehouse, kindergarten should be tagged separately.

Note that it is about amenity=public_building, not building=public_building.

@matkoniecz
Copy link
Member Author

To be clear, building=public_building is perfectly fine and requires no compline.

@derfasthirnlosenick
Copy link

Seems similar to #112 and #314 - we (as of now) have no standard way of showing that someone went and verified the info that is stored on osm. This means we either
a) use some method to store the info on osm (lastcheck or similar tag, touching the node, ...). Might ruffle some feathers.
b) unchanged/verified info is just stored locally - every other user will still see the quest. Might create some double-work.

b) might be a good way to test whether the value-add from such verification is worth the possible disruption caused. This would need 3/4 things:

  1. Implementation of the quests of interest
  2. An "Einzelkämpfer“ setting/build that triggers these quests - in order to avoid annoying/overwhelming normal users
  3. A way to generate a report on the verification (e.g. for type A quests, the user had X times no change, Y times change to parameter A, ...) - this would enable a more informed discussion.
    (4. In case data (date/time, result) is stored on the "no change" quests, this info could potentially be written into OSM once a concrete decision is taken - I'd be quite cautious with this one though as that could screw up things.)

I guess as long as nothing is written on osm, there is no harm done to the greater OSM community.

@rugk
Copy link
Contributor

rugk commented Jul 2, 2017

@derfasthirnlosenick I think for the current stage it is not worth to discuss it. (Or either, in a separate issue.) The current policy is (nearly) no false-positives.

In any case looking at this quest suggestion, I think it is not that bad. First of all amenity=public_building is a discouraged tag, so (hopefully) there should not be that many buildings tagged with it. So basically this quest would be about cleaning up a type of discouraged tags by making them more specific.

So, now second question: Can the user usually reasonably decide what type of building this is?
Seeing the list of possible buildings, I clearly think, yes. The reason is that mos of these types of buildings have a plate/text somewhere stating what it is (library or so).
Only townhall, community_centre and sports_centre could get difficult, but in this case I just hope that not so many townhalls exist in one place (:wink:) and other wrongly tagged public_buildings are rare.

@matkoniecz
Copy link
Member Author

After real world fixing of this problem - in most cases it is fixable without resurvey, in remaining one note may be opened.

I decided against implementing it even for my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants