-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opening_hours:lastcheck #314
Comments
opening_hours:lastcheck is very rarely used and has no wiki page https://taginfo.openstreetmap.org/keys/opening_hours%3Alastcheck#wiki there is https://wiki.openstreetmap.org/wiki/Key:check_date that may or may not be more popular |
Also needed for #112 I'd say that there not being a clear consensus shouldn't deter from using one of the tags as the usefulness is quite high. |
I kinda do not like to put data like this into the map itself. I thought putting things like You can get the last edit date of any such tags by digging through the element history, JOSM has this feature. Of course, I have to admit that it is unnecessarily complex. I'd rather much like an OSM API addition that simply adds a ... So, I don't know. Perhaps add a checkdate tag after all and hope that this will somehow be added to the api later (as it had been done with the introduction of changesets) when power users complain about being swamped by In any case, this ticket should be about adding a check_date for ALL changes that are made through StreetComplete. |
Thinking about it, I think one could conclude from looking at the last edited date of any element whether an element requires re-survey in general (regardless of specific tags) or not. I.e. if a node tagged with |
I guess for the time being, there's only a handful of things that would warrant a timestamp of the last survey:
As you said, existence of a business probably could be done by last change to the node instead of a survey date. Construction sites would be a new quest ("is this site still under construction?"), so only for hours the current behavior would change. For everything else, there's almost no downside to not having the tag. If OSM allows us to put the last changeset of the parameter, that'd be fine I guess. If this isn't possible, adding survey dates for a few select parameters might be the most sensible option. |
Thought about it once more and figured out my old rationale again.
Existence of a shop would be covered by this as well, since the check would issue a changeset. |
Main problem is that app starting to use nonstandard tag will be certainly controversial (complaints will mention littering in tag properties, using weird tags and claim that it is undiscussed mass edit/import/evil). I am not sure is it a good idea, though currently there is no good way to differentiate between stable and outdated opening hours. |
One thing to consider: It should be possible to "touch" elements by uploading them into a changeset without any actual change. This will change the version number and last edited date. Whether this technique is preferable or not is open for discussion.
Am 14. Juni 2017 08:20:46 MESZ schrieb derfasthirnlosenick <notifications@github.com>:
…Thought about it once more and figured out my old rationale again.
If a shop is resurveyed, there are two options:
1. There are changes -> update indicated by changeset date
2. There are no changes -> no changesset, therefore noone knows if the
info is current or not.
https://wiki.openstreetmap.org/wiki/Key:check_date specifically
mentions construction sites, opening hours and collection times and
recommends mapping parties for elements with potentially outdated info.
Existence of a shop would be covered by this as well, since the check
would issue a changeset.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#314 (comment)
--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.
|
Will reconsider for next release |
Alright, I thought about this once more, also because I got the feature request from my local community to add I decided that this app will not add The reason is that such scripts which look for possibly outdated information will need to not only look for elements with It is now possible with Overpass, to filter by changed date, so it is technically relatively easy to do. I think it very much makes sense to tag |
Hallo,
ich habe die Tage ein paar Öffnungszeiten mit StreetComplete hinzugefügt.
Wenn ich dies normal via JOSM erledige, füge ich immer noch den "lastcheck" hinzu.
Daher meine Frage / Anmerkung ob es möglich wäre, bei einem Öffnungszeiteneintrag automatisch auch den "opening_hours:lastcheck" Stempel mit dem aktuellen Datum zu setzen.
Beste Grüße
The text was updated successfully, but these errors were encountered: