-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quest: support trees #83
Comments
A common tag is also So maybe let's have a 'be sure of what you're doing' before the user inputs a scientific name in the |
Let them pass a simple English or localises test first. |
Mmh, maybe not the most urgent quest to implement. |
Agreed, nevertheless a valuable one. Perhaps only start on this when offering a compulsory user test to check if they know what they are doing is easily available in street complete. |
I used to have
Overall, I would not recommend adding this quest. |
Hmm… do they map forests as single trees where you use StreetComplete? 😆 😉 Maybe also consider #366 the follow-up of this issue and maybe generally the better idea. As the implementation should be the same for both quests, however, one may e.g. just include the tree rows in the other quest there. |
Yes, in my city some parks have individual trees mapped. Maybe in places with only major trees mapped it would be less flustering. |
Some cities in the Netherlands have exported their tree databases under an open license and these have been imported into OSM. So some cities have tens of thousands of individual trees. Here is an example. F4 uses It is certainly not to be used for forests, only for individual trees which are missing these details. See, as @rugk also mentions, #366 for more fine-tuned approach. |
Hmm, ok. Now we have one argument in favor of this quest (F4) and one against it (the database import)… However, once trees are mapped, they are mapped… 😐 |
If a tree is mapped, it can still be missing:
Especially the man-made nesting site is very interesting addition to be made by StreetComplete users as they are usually not part of the open tree database from local governments. Note that natural nesting sites are not to be mapped. See also https://wiki.openstreetmap.org/wiki/Talk:Proposed_features/Nesting_Site#Nest_for_bats_on_a_tree and https://wiki.openstreetmap.org/wiki/File:Nest-for-bats.jpg |
Uh, that is getting very much… Please note StreetComplete quests should not spam users. And I am very sure most trees do not have such a nesting site. Also I do not see a concrete use case, just because it is not mapped in government databases. And generally, I'd say this is a new quest type, so next time, just directly open a new issue. (and fill out/check the issue template) |
Agreed, so only |
To keep it practical, query only If |
The query should perhaps also include leaf_type values that aren't 'broadleaved|needleleaved|leafless' for |
That is a poor idea, except cases that are clearly missing data (like access=unknown for parking access quest) existing data should not be overwritten silently. |
Agree with @matkoniecz because this could overwrite (unwillingly,unknowingly) new tags which are in the making or starting to be used. I doubt it will apply here, but better to be strict. By the way, leafless applies to huge cacti which are added as a tree or dead trees (which should be tagged as a pole or something else, as the original tree did have a leaf type). so I would recommend to stay away from leafless too. |
Based on @matkoniecz experiences with a prototype version of the quest, and the fact that he already implemented quests for leaf-cycle for (small) forest patches, I will close this ticket as will not fix. To summarize:
So, the latter is a real problem that can and will lead to wrong data entered by the users. |
I know, this quest was closed, but I would ask to reopen it:
I would ask to reopen because of a current research issue where this kind of information would be really helpfull (so really NOT useless) |
Tree rows are supported already in the leaf type quest. Even if single tree is mapped then multiple trees may be in a given place. |
Yes, the suggestion was to also include genus or species |
If you have an idea how to: deal with mixed tree rows (multiple species) and allow tagging species or genus by mapper without botanical experience, without making code as complex as all other quests taken together then feel free to open a new issue and feel the template But I am sceptical about species or even genus tagging with SC, it sounds extremely complex or requiring user to have some botanical experience. I am familiar with tree identification flowcharts and following them is not trivial. I bet that leaf cycle quest is more viable, but still may be a bit too much. |
I agree, specialized MapComplete map for such quests requiring special knowledge might be much better match than StreetComplete. |
A specialized app would be a lot of code duplication/maintenance effort. Then, rather a plugin system for SC adding more quests would be appropiate. This was raised a long time ago in #98 in some way, though it focused on a JSON format, while I would nowadays prefer just native code/apps that you can download. If you want to re-raise it, maybe collect a list of quests (issues here) that would be suitable, find out whether the interface SC nowadays uses for quests is appropriate/can somehow theoretically be extended and then document that in a new issue. Edit: Also raised in #1027, see the arguments there. |
Perhaps in the future, StreetComplete can have special modules that are unlocked for contributors which have a high quality track record and then did some 'entrance quests' for which we know the answers, in order to do more advances quests, such as tree circumference. |
Not really. You can maintain version with own quests fairly easily (I know because I am doing this). |
It becomes difficult for mappers when you have a number of different SC forks installed though, and I still think the effort to maintain and do releases is significant. I would love to be able to have a tree quest as originally described here, and do understand why it might not be enabled by default, but I still think it's better have an an experimental trees quest included in SC rather than in a SC for trees fork. |
@andrewharvey perhaps those different quests could be kept in one experimental fork? see @Helium314 et al. suggestion at #3003 (comment) |
These days, I'd recommend to people interested in this subject to try out Every Door. As is StreetComplete, EveryDoor is also simple to use app, but seems much better match for this use case (as opposed to SC Quests), and already implements this feature, e.g. |
partial implementation of streetcomplete#83
* better file name * ask about leaf type of natural=tree partial implementation of #83 * better English Co-authored-by: Flo Edelmann <git@flo-edelmann.de> * exclude cases where this info is implied by other tags * add test to common test base * skip more tags indicating leaf_type * fix code and tests * more readable filter Co-authored-by: Flo Edelmann <git@flo-edelmann.de> * collapse line Co-authored-by: Flo Edelmann <git@flo-edelmann.de> * smarter filter of already tagged data Co-authored-by: Tobias Zwick <newton@westnordost.de> * enable deleting trees in leaf type quest * disable tree quest by default * remove tests as requested --------- Co-authored-by: Flo Edelmann <git@flo-edelmann.de> Co-authored-by: Tobias Zwick <newton@westnordost.de>
Just FYI for those following this issue: nowadays, For those wanting more details SCEE (StreetComplete "Expert Edition" fork) also has an advanced quest for species/genus taxon of the tree. |
Please add support for individual trees, see https://wiki.openstreetmap.org/wiki/Tag:natural%3Dtree
Make sure only to offer one-of-many choices such as
leaf_type
,genus
,species
and/or (when applicable for the species)sex
. Note that for these four values, many can be derived when the most specific was chosen in the app. Best to consult the decision tree with a tree expert / botanist.Other values such as
taxon
,name
,circumference
,height
,diameter_crown
andstart_date
are to be derived (taxon) or difficult to impossible to simply observe by looking and should not be offered.The text was updated successfully, but these errors were encountered: