Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest: support trees #83

Closed
PanderMusubi opened this issue Apr 2, 2017 · 29 comments
Closed

Quest: support trees #83

PanderMusubi opened this issue Apr 2, 2017 · 29 comments
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@PanderMusubi
Copy link
Contributor

Please add support for individual trees, see https://wiki.openstreetmap.org/wiki/Tag:natural%3Dtree

Make sure only to offer one-of-many choices such as leaf_type, genus, species and/or (when applicable for the species) sex. Note that for these four values, many can be derived when the most specific was chosen in the app. Best to consult the decision tree with a tree expert / botanist.

Other values such as taxon, name, circumference, height, diameter_crown and start_date are to be derived (taxon) or difficult to impossible to simply observe by looking and should not be offered.

@westnordost westnordost added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Apr 3, 2017
@nicolasmaia
Copy link

nicolasmaia commented Apr 7, 2017

A common tag is also species:foo where "foo" is a two-digit language code. This is used for common names. I think it would be useful to have this as more regular people (non-wizards) know the common names rather than the scientific names. The relevant lang code can be pulled from the system language.

So maybe let's have a 'be sure of what you're doing' before the user inputs a scientific name in the species field, or worse: the user adds a comon name into the species field.

@PanderMusubi
Copy link
Contributor Author

Let them pass a simple English or localises test first.

@PanderMusubi PanderMusubi changed the title Add support for trees Quest: support trees Apr 9, 2017
@Jotam
Copy link

Jotam commented Apr 19, 2017

Mmh, maybe not the most urgent quest to implement.

@PanderMusubi
Copy link
Contributor Author

Agreed, nevertheless a valuable one. Perhaps only start on this when offering a compulsory user test to check if they know what they are doing is easily available in street complete.

@matkoniecz
Copy link
Member

matkoniecz commented Feb 26, 2018

I used to have leaf_cycle and leaf_type quests in my fork but I removed them because

  • individual trees are impossible to precisely locate during survey and I was never sure whatever I am answering correctly. Maybe it would be improved by map showing locations of trees - but it is rejected by guidelines for SC map style
  • quests turned out to be extremely boring, even for somebody who really loves nature
  • I had constant feeling that solving this quests is a complete waste of time

Overall, I would not recommend adding this quest.

@rugk
Copy link
Contributor

rugk commented Feb 26, 2018

Hmm… do they map forests as single trees where you use StreetComplete? 😆 😉
Because otherwise you may only find these in parks or some single ones at streets or so. I think they are both always the same (when in a row or so) and less often different when standing near each other,
And in parks one may not have too many trees at once to answer. I think there can hardly be a quest, which is even more boring than the street surface one in cities… 😉 That's why I just move it down from the priority.
So I still consider this not soo bad, maybe limit it to tree rows or so… (then you only answer once for a row, similar to how you do it for a street)

Maybe also consider #366 the follow-up of this issue and maybe generally the better idea. As the implementation should be the same for both quests, however, one may e.g. just include the tree rows in the other quest there.

@matkoniecz
Copy link
Member

Yes, in my city some parks have individual trees mapped. Maybe in places with only major trees mapped it would be less flustering.

@PanderMusubi
Copy link
Contributor Author

Some cities in the Netherlands have exported their tree databases under an open license and these have been imported into OSM. So some cities have tens of thousands of individual trees.

Here is an example. example F4 uses leaf_type to render the correct shape of tree.

It is certainly not to be used for forests, only for individual trees which are missing these details. See, as @rugk also mentions, #366 for more fine-tuned approach.

@rugk
Copy link
Contributor

rugk commented Feb 27, 2018

Hmm, ok. Now we have one argument in favor of this quest (F4) and one against it (the database import)…

However, once trees are mapped, they are mapped… 😐

@PanderMusubi
Copy link
Contributor Author

PanderMusubi commented Feb 27, 2018

If a tree is mapped, it can still be missing:

  1. leaf type
  2. leaf cycle
  3. an optional node relation for a man-made nest with:
    • man_made=nesting_site
    • support=tree
    • material=plastic, material=metal or material=wood
    • taxon:order=Chiroptera (for bats) or taxon:class=Aves (for birds)
    • (Omit species, genus and capacity as this is hard to observe or determine. Perhaps also store somehow that there is no man-made nest?)

Especially the man-made nesting site is very interesting addition to be made by StreetComplete users as they are usually not part of the open tree database from local governments. Note that natural nesting sites are not to be mapped.

example

See also https://wiki.openstreetmap.org/wiki/Talk:Proposed_features/Nesting_Site#Nest_for_bats_on_a_tree and https://wiki.openstreetmap.org/wiki/File:Nest-for-bats.jpg

@rugk
Copy link
Contributor

rugk commented Feb 27, 2018

Uh, that is getting very much…

Please note StreetComplete quests should not spam users. And I am very sure most trees do not have such a nesting site.

Also I do not see a concrete use case, just because it is not mapped in government databases.

And generally, I'd say this is a new quest type, so next time, just directly open a new issue. (and fill out/check the issue template)

@PanderMusubi
Copy link
Contributor Author

Agreed, so only leaf type and leaf cycle then.

@PanderMusubi
Copy link
Contributor Author

To keep it practical, query only leaf_type. In OSM natural=tree occurs 10,211,795 times. Of which 7,538,527 trees are missing leaf_type and 12,236 trees have leaf_type=mixed, which is not allowed for a tree.

If natural=tree has is missing leaf_type or has leaf_type=mixed, offer the user only leaf_type=broadleaved or leaf_type=needleleaved to choose from.

@goldfndr
Copy link
Contributor

goldfndr commented Mar 1, 2018

The query should perhaps also include leaf_type values that aren't 'broadleaved|needleleaved|leafless' for natural=tree, to fix up the mistagged trees. (It seems like leafless should maybe be spineleaved, given the accompanying images.)

@matkoniecz
Copy link
Member

The query should perhaps also include leaf_type values that aren't 'broadleaved|needleleaved|leafless' for natural=tree, to fix up the mistagged trees.

That is a poor idea, except cases that are clearly missing data (like access=unknown for parking access quest) existing data should not be overwritten silently.

@PanderMusubi
Copy link
Contributor Author

Agree with @matkoniecz because this could overwrite (unwillingly,unknowingly) new tags which are in the making or starting to be used. I doubt it will apply here, but better to be strict.

By the way, leafless applies to huge cacti which are added as a tree or dead trees (which should be tagged as a pole or something else, as the original tree did have a leaf type). so I would recommend to stay away from leafless too.

@westnordost
Copy link
Member

Based on @matkoniecz experiences with a prototype version of the quest, and the fact that he already implemented quests for leaf-cycle for (small) forest patches, I will close this ticket as will not fix.

To summarize:

  • type of single trees are rather unimportant, mostly only useful for 3D rendering
  • highly repetitive (waste of time)
  • tree type (coniferous or broadleaved) can often be determined easily from good areial imagery
  • Most importantly:

individual trees are impossible to precisely locate during survey and I was never sure whatever I am answering correctly.

So, the latter is a real problem that can and will lead to wrong data entered by the users.

@westnordost westnordost added wontfix idea rejected because it is out of scope or because required work is not matching expected benefits and removed new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) labels Sep 6, 2019
@TraWELTina
Copy link

TraWELTina commented Jul 13, 2021

I know, this quest was closed, but I would ask to reopen it:

  • the tree species has valuable application for research (e.g. used for the monitoring of insects which are specific to certain trees)
  • if determining the "right" tree is hard, can one probably add a filter, to not include trees that are standing too close?
  • tree rows can be probably mapped together as they are mostly the same tree type (so that its not too repetitive)
  • botanists/experts could provide the decision images

I would ask to reopen because of a current research issue where this kind of information would be really helpfull (so really NOT useless)

@matkoniecz
Copy link
Member

matkoniecz commented Jul 13, 2021

Tree rows are supported already in the leaf type quest.

Even if single tree is mapped then multiple trees may be in a given place.

@TraWELTina
Copy link

TraWELTina commented Jul 13, 2021

Tree rows are supported already in the leaf type quest.

Yes, the suggestion was to also include genus or species

@matkoniecz
Copy link
Member

If you have an idea how to:

deal with mixed tree rows (multiple species)

and

allow tagging species or genus by mapper without botanical experience, without making code as complex as all other quests taken together

then feel free to open a new issue and feel the template

But I am sceptical about species or even genus tagging with SC, it sounds extremely complex or requiring user to have some botanical experience.

I am familiar with tree identification flowcharts and following them is not trivial.

I bet that leaf cycle quest is more viable, but still may be a bit too much.

@mnalis
Copy link
Member

mnalis commented Aug 30, 2021

allow tagging species or genus by mapper without botanical experience, without making code as complex as all other quests taken together
But I am sceptical about species or even genus tagging with SC, it sounds extremely complex or requiring user to have some botanical experience.

I agree, specialized MapComplete map for such quests requiring special knowledge might be much better match than StreetComplete.

@rugk
Copy link
Contributor

rugk commented Aug 30, 2021

A specialized app would be a lot of code duplication/maintenance effort. Then, rather a plugin system for SC adding more quests would be appropiate. This was raised a long time ago in #98 in some way, though it focused on a JSON format, while I would nowadays prefer just native code/apps that you can download.

If you want to re-raise it, maybe collect a list of quests (issues here) that would be suitable, find out whether the interface SC nowadays uses for quests is appropriate/can somehow theoretically be extended and then document that in a new issue.

Edit: Also raised in #1027, see the arguments there.

@PanderMusubi
Copy link
Contributor Author

Perhaps in the future, StreetComplete can have special modules that are unlocked for contributors which have a high quality track record and then did some 'entrance quests' for which we know the answers, in order to do more advances quests, such as tree circumference.

@matkoniecz
Copy link
Member

A specialized app would be a lot of code duplication/maintenance effort.

Not really. You can maintain version with own quests fairly easily (I know because I am doing this).

@andrewharvey
Copy link
Contributor

Not really. You can maintain version with own quests fairly easily (I know because I am doing this).

It becomes difficult for mappers when you have a number of different SC forks installed though, and I still think the effort to maintain and do releases is significant.

I would love to be able to have a tree quest as originally described here, and do understand why it might not be enabled by default, but I still think it's better have an an experimental trees quest included in SC rather than in a SC for trees fork.

@mnalis
Copy link
Member

mnalis commented Sep 2, 2021

@andrewharvey perhaps those different quests could be kept in one experimental fork? see @Helium314 et al. suggestion at #3003 (comment)

@mnalis
Copy link
Member

mnalis commented May 12, 2023

These days, I'd recommend to people interested in this subject to try out Every Door.

As is StreetComplete, EveryDoor is also simple to use app, but seems much better match for this use case (as opposed to SC Quests), and already implements this feature, e.g.

small_Screenshot_20230512_195032_info zverev ilya every_door

matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Feb 22, 2024
westnordost added a commit that referenced this issue Mar 3, 2024
* better file name

* ask about leaf type of natural=tree

partial implementation of #83

* better English

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

* exclude cases where this info is implied by other tags

* add test to common test base

* skip more tags indicating leaf_type

* fix code and tests

* more readable filter

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

* collapse line

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

* smarter filter of already tagged data

Co-authored-by: Tobias Zwick <newton@westnordost.de>

* enable deleting trees in leaf type quest

* disable tree quest by default

* remove tests as requested

---------

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Tobias Zwick <newton@westnordost.de>
@mnalis
Copy link
Member

mnalis commented May 10, 2024

Just FYI for those following this issue: nowadays, Things overlay can be used to add trees as POIs in StreetComplete (and there is a quest for leaf type too).

For those wanting more details SCEE (StreetComplete "Expert Edition" fork) also has an advanced quest for species/genus taxon of the tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

No branches or pull requests

10 participants