Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reword parking access - #3429 #3473

Merged
merged 4 commits into from
Nov 11, 2021

Conversation

matkoniecz
Copy link
Member

primary problem was that publicly owned parking may have private access (say, parking where just president of city is allowed to park) and private parking may have public access (say, paid parking near airport on private grounds)

previous wording was not fully solving it and was still confusing

this rewording tries to clarify what exactly is being asked

Note that especially wording about customers is not 100% fully succesful, but seems the best found so far

primary problem was that publicly owned parking may have private access (say, parking where just president of city is allowed to park) and private parking may have public access (say, paid parking near airport on private grounds)

previous wording was not fully solving it and was still confusing

this rewording tries to clarify what exactly is being asked

Note that especially wording about customers is not 100% fully succesful, but seems the best found so far
Copy link
Member

@smichel17 smichel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been confused before, when answering this quest. However, it's mostly not the fault of the quest; in many situations (when it is not signed), I just don't know what the rules actually are— who owns/maintains the parking lot & whether non-customers are allowed to park there.

I am also not sure I fully understand the distinction between private and customers. Perhaps you could share a more technical definition, and I can try to come up with a good phrasing for that? (edit: answered in #3473 (comment) & below)

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@mnalis
Copy link
Member

mnalis commented Nov 1, 2021

I'm OK with customers => Open only to people visiting a specific place (e.g. customers)

For private, it is currently too similar to yes text, so maybe Forbidden to general public would fit better? (or is it Forbidden for general public?)

Also of note, yes => Open to general public in this PR seems to have lost the explanation (with or without fee), which I remember I had found useful when I was starting with SC for parkings, so others might have too, so I'd vote for reinstating that part if possible.

@matkoniecz
Copy link
Member Author

matkoniecz commented Nov 1, 2021

seems to have lost the explanation (with or without fee),

It was moved to the quest title.

Who may park here? Parking may be free or paid.

Copy link
Member

@smichel17 smichel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be some additional room for improvements, but I think this is pretty good (better than my previous suggestion).

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@westnordost
Copy link
Member

What is the status of this ticket?

Co-authored-by: smichel17 <github@smichel.me>
@matkoniecz
Copy link
Member Author

I was unsure which wording would be better and hoped for consensus of English speakers.

On review @smichel17 version seems nicer than mine so I applied it.

Noone protested that it is a poor idea so it should be ready for merging? I would welcome at least one person reviewing it though.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I'm not a native speaker)

@westnordost westnordost merged commit a5def4c into streetcomplete:master Nov 11, 2021
@smichel17
Copy link
Member

I was unsure which wording would be better and hoped for consensus of English speakers.

For the future, it would be good to request a review. Even when watching everything, it's sometimes easy to miss that your input would be useful, or required… even on my own PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants