-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reword parking access - #3429 #3473
Conversation
primary problem was that publicly owned parking may have private access (say, parking where just president of city is allowed to park) and private parking may have public access (say, paid parking near airport on private grounds) previous wording was not fully solving it and was still confusing this rewording tries to clarify what exactly is being asked Note that especially wording about customers is not 100% fully succesful, but seems the best found so far
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been confused before, when answering this quest. However, it's mostly not the fault of the quest; in many situations (when it is not signed), I just don't know what the rules actually are— who owns/maintains the parking lot & whether non-customers are allowed to park there.
I am also not sure I fully understand the distinction between private
and customers
. Perhaps you could share a more technical definition, and I can try to come up with a good phrasing for that? (edit: answered in #3473 (comment) & below)
I'm OK with For Also of note, |
It was moved to the quest title.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be some additional room for improvements, but I think this is pretty good (better than my previous suggestion).
What is the status of this ticket? |
Co-authored-by: smichel17 <github@smichel.me>
I was unsure which wording would be better and hoped for consensus of English speakers. On review @smichel17 version seems nicer than mine so I applied it. Noone protested that it is a poor idea so it should be ready for merging? I would welcome at least one person reviewing it though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but I'm not a native speaker)
For the future, it would be good to request a review. Even when watching everything, it's sometimes easy to miss that your input would be useful, or required… even on my own PRs! |
primary problem was that publicly owned parking may have private access (say, parking where just president of city is allowed to park) and private parking may have public access (say, paid parking near airport on private grounds)
previous wording was not fully solving it and was still confusing
this rewording tries to clarify what exactly is being asked
Note that especially wording about customers is not 100% fully succesful, but seems the best found so far