-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add smoothness quest #3617
Add smoothness quest #3617
Conversation
Co-authored-by: Tobias Zwick <newton@westnordost.de>
# Conflicts: # app/src/main/java/de/westnordost/streetcomplete/data/user/achievements/AchievementsModule.kt # app/src/main/java/de/westnordost/streetcomplete/quests/QuestModule.kt # app/src/main/res/values/strings.xml
# Conflicts: # app/src/main/java/de/westnordost/streetcomplete/quests/surface/AddRoadSurface.kt
I think it's the other way around: the use case is that we want map users to be able to decide whether a way can be used with their vehicle, or should be avoided. "Smoothness" is a measure of usability, not the other way around. Usability is unfortunately rather subjective, so I tried to make it less so by adding the descriptions column in the wiki (where the appearance of the surface is just one of the criteria, together with need to reduce speed and ground clearance). I think if we have a choice between a tag that is very useful, but subjective, and one that is objective, but useless, we should go for the first. |
@rhhsm I understand you added the descriptions column in the wiki only a year ago. (Which was even after the Verkehrswende/smoothness page was created and discussed.) But as you wrote yourself in your last comment, you added it to make the selection less subjective, i.e. less dependent on what each individual would classify as "usable". And you certainly didn't pull this description out of your ass, you carefully thought of which objective criteria could be named that makes a surface being properly usable by a certain vehicle type. What is being refined here is to mention surface-specific properties in the descriptions such as the gaps between and shapes of the stones (for paving stones, sett), damage like potholes and ruts (for asphalt), erosion damage (for unpaved surfaces) etc. to make it even more objective and clear. Same for pictures. This doesn't make So, in short, I fiercely deny your claim that this implementation doesn't follow consensus or that it sets its own standards only because it does not mention "usable by XYZ". As I (in the FAQ) and others wrote before, for an on-site contributor, "usable by racing bike" is a relatively useless hint unless the particular surveyor happens to be on or at the very least owns a racing bike and ranks average on the "careful-venturesome" scale. |
I think we have to accept the fact that to be able to tag this correctly (objectively and consistently), some reading is required. Would it be possible to add an introductory text (or a reference to the wiki) the first (few) times a SC user attempts to solve this kind of quest? Maybe it could be deselected by default, and to be selected, the user has to confirm that he understands the details of the tag and has read the wiki (similar to the speed limit quest)? |
It's from this picture (click). I know, "usable by" can be widely interpreted. What seems to have emerged from the long community process of selecting the pictures (I mean both in the last ticket and in the Verkehrswende wiki), is the interpretation that this means it is OK to use. I.e. maybe not entirely without issue, but still in the range of normal usage. |
I went through the whole PR and its contributions again, uploaded all the pictures I found most representative to the openstreetmap wiki that weren't yet and weren't yet on wikimedia commons and created this page: https://wiki.openstreetmap.org/wiki/Key:smoothness/Gallery This page not only includes the pictures chosen to be displayed in the app, but many more that have been contributed along the way. I thought it would be a waste to throw this away. Feel free to extend or refine it. Many surface types are missing, some surface + smoothness combinations could use some more example pictures on variations. |
You would certainly need robust_wheels to do this road, but high_clearance doesn't help. I find it hard to image that there are roads that need high clearance to navigate but can still be considered paved, and the difficulty in finding good pictures of such roads is evidence for this. That's why I started the description of very_bad in the wiki with "Unpaved roads with ...". Most of the pictures in the very_bad column of the wiki gallery (thanks for adding!) don't need high clearance either (only the pictures of General_Wade.., smoothness_very_bad and Mountain_path... show some large rocks that could really kill the oil pan of your normal car).
It's why I suggested in the wiki that a mapper should consider whether he would recommend the way to a friend, or recommend to avoid it by taking a detour that is 30% longer. I also proposed that only 4-wheeled vehicles should be considered, because for a bike you need only 20 cm of good surface to make it usable. Potholes etc. are much easier to avoid on a 2-wheeler, so what matters is if they are avoidable or not for a 4-wheeler. However there was no consensus for this.
What do you think about my suggestion above? |
The smoothness wiki page does quite a bad job to be helpful for someone on-site to decide on the right category. Anything helpful from the wiki page has already been incorporated in the app. Note that users of the app don't even see the What really helps in making contributors use the tag more consistently/objectively is a unified scale with descriptions and example pictures where the roughness/usability of each example picture of different |
thanks @1ec5 for finding some missing fitting pictures for very good and very bad concrete |
app/src/main/java/de/westnordost/streetcomplete/quests/smoothness/SmoothnessItem.kt
Show resolved
Hide resolved
How about also adding some text like:
(take them as an example, I'm not that good at copywriting 😆) The essence is telling the user what the icon is intended to represent without being boring (in StreetComplete-style). I think most users wouldn't care (or even notice) the link between the emoji icon and the surface for some time before they actually pay attention to it, so this could help at the beginning, then they will just look at the icon to identify what each surface is intended for. |
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
@Helium314 you can remove my permission now |
Alright guys, here is the new PR that fixes #1630. I created a new one because the old one (#3257) already had so many comments that it became quite messy. So here is a summary.
Since by now, so many people are involved and engaged in this PR by researching, by collecting photos and otherwise, I took great care to check and refine the texts again for conformity with the following sources:
I also looked through all the photo collections contributed so far, either by linking to some wikimedia commons or by actually posting collections of self-made photos. Thanks again everyone for contributing, here is a summary of photo collections posted that I had a deeper look into:
For the photos, too, I took great care with the selection of the photos and supplied reasons why I chose one photo over the other further below
I put both the now selected pictures and the adapted wordings into this document (click!):
Thanks for starting that document, @tordans!
The wordings take a lot from the wiki page on smoothness and the "Zusammenfassung/Faustregeln" from the Verkehrswende/smoothness page, which nicely complement with each other.
FAQ
I also scanned the old PR #3257 for any decisions and reasons for these made there and summarized them:
Why ask for "surface quality" and not simply for "smoothness", as this is also the tag's name?
@smichel17 wrote earlier:
Why not use the smoothness values as titles?
@Helium314 wrote earlier:
So, it is better to describe the bumpyness than to describe how "good" or "bad" they are because the latter is connected with the surface type. The literal tag value is judgemental and may only help people both using the US-English locale on their phone and knowing the tagging scheme (well). For the rest, it may actually be more confusing than helpful.
Why not mention how much cars would need to slow down in descriptions? (wiki does)
@smichel17 wrote earlier:
So, if there is a
bad
surface and a speed limit of 30 kph in a residential area, it doesn't really affect the max speed a car goes. Instead of referring to how much cars have to slow down, we mention that the smoothness (starting withvery_bad
is potentially dangerous), i.e. caution by whoever uses it is advised, i.e. they have to slow down considerably.Why show emojis for the vehicle types?
The wiki mentions some vehicles in the "usable by" column. We chose to just display a small emoji with such a vehicle type because
Why not mention concrete cm-limits for crack widths? (wiki does)
Exact measures for maximum crack widths seems to be an objective measure at first, but it is not that great after all:
A road that has some cracks, has lots of them. Nobody is going to run around and measure every single crack. See e.g. this picture for intermediate asphalt on the wiki. Is there any crack above 2cm in width? Such an exact measurement will make it harder, not clearer or easier to record the right value because the user has to make his decision based on the big picture, not some details at some spot. Let's not fool ourselves, the
surface
tag is an approximate.So, one reason the vehicle type emoji is shown is to suggest to users that using that vehicle('s tires) are still OK, and for which tires a crack causes problems is a better measurement than exact centimeters.
What are the picture selection criteria?
Alternative candidates for pictures
...that I considered. In the end, only one picture could be selected, so here are the (sometimes quite unimportant) reasons why the picture was not selected
Asphalt
excellent
intermediate
good
good
bad
bad
bad
but forintermediate
in the wiki. IMO it's ratherbad
, but the fact that it is an example forintermediate
on the wiki disqualifies it forbad
bad
on Verkehrswende/smoothness. Even though it shows definitely more damages than the typicalintermediate
road, it is a bit on the upper end ofbad
(compare withbad
paving stones/sett etc)very bad
horrible and very horrible:
Paving stones
excellent
good
intermediate
bad
(?)bad
excellent
or at leastgood
very bad
Sett
good
intermediate
already. The rest is a little colorful / showing the granite pattern a little muchgood
smoothness is achievable with large stones toointermediate
good
, unusual patterngood
. Even though they have a rough surface, such stones feel mostly the same as "normal" concrete paving because they are very regular and the granularity of the surface too fine that it would matter much on anything except the tinyiest wheelsbad
intermediate
even though they look a bit broken, 4_bad_3 and 4_bad_4 are difficult to see/blurry and 4_bad_2 is good but not better fitting than current picture or the ones from @NicoHoodvery_bad
but IMO looks more likebad
compacted
intermediate
fine_gravel
(maybe prompting users to say that the surface displayed is not the correct one), current picture is more inclusive in that it is clear that more loamy surfaces are alsocompacted
bad
horrible
dirt
/ground
roads. Compacted roads usually have larger gravels below the finer gravel surface, so if they become damaged erosion, the bigger stones surfacegravel
intermediate
bad
bad
bad
orvery_bad
very bad
bad
orvery_bad
horrible
very_bad
What could be improved
Note the picture guidelines.
Would be good:
very bad
).bad
and below paving stones are usually damaged, cracked, displaced, uneven, rough ones etc. - current ones are so-sointermediate
paving stones: photograph from closer to the ground at steeper angle like with most pictures from Verkehrswende/smoothness) OR find a different picture that fits. Loose-looking stones are a bit uncommon. Current photo is from @Helium314Not that important:
excellent
paving stones: photograph from closer to the ground at steeper angle (like with most pictures from Verkehrswende/smoothness). Current photo is from @mcliquidgood
sett: photograph from closer to the ground at steeper angle (like with most pictures from Verkehrswende/smoothness). Current photo is from @NicoHoodbad
sett: current picture tends towardsintermediate
(visually). A similar photograph (same perspective etc.) but with some irregularly shaped, more weathered and/or broken stones mixed in would be a better picture.very bad
sett: use different perspective - from closer to the ground, down the street. Current photo is from @westnordost