Camping site quests

[mnalis]

This implements some (but not all) of requested quests for tourism=camp_site, thus it mostly fixes #4198:

• drinking_water=* yes/no quest
• power_supply=* yes/no quest
• shower=* yes/no quest
• 3-answer quest Who may camp here? ( Tents only / Caravan only / Both) for setting tents=* and caravans=* (with OtherAnswer available to set backcountry=yes)
• create non-placeholder icons

Help needed with icons: This PR reuses icon for ic_quest_drinking_water (which might be OK as it is, or it might benefit from being separate icon, e.g. if all icons have tent+some_image), but has only placeholder icons for ic_quest_camp_power_supply, ic_quest_camp_shower and ic_quest_camp_type. Artistically inclined people are invited to fix those!

[matkoniecz]

It is in the draft state - do you expect review of what is prepared?

Or is it request for help with some part (which one)?

[mnalis]

Code is tested and looks to work OK to me, so ready for review.
It needs replacing placeholder icons however, which needs someone artistically inclined (as noted in updated PR summary).

[FloEdelmann]

Looks good :)
I have some quest filter formatting suggestions (to be consistent with existing quest filters) that I'll apply directly; please feel free to overwrite them again if they're not perfect.

I'm not approving, since real icons are still missing.

[peternewman]

Some improvements/suggestions and comments.

[westnordost]

(Just ping me if this is ready for final review. I haven't been following this PR. As usual, icons are not required, I'll make them if they are missing.)

[matkoniecz]

tested in emulator, I have this suggestion mentioned above - but not 100% sure is it useful

recently I was talking with friends and it turns out that in some regions even "is this camping site paid" maybe would be a viable quest

[mnalis]

(Just ping me if this is ready for final review. I haven't been following this PR. As usual, icons are not required, I'll make them if they are missing.)

Thanks @westnordost, I've tried playing with icons but got stuck at transparency/fill issues, so I'd appreciate if you can take care of icons when you do final review!

Other than that, I think it's as finished as I could make it.
Two more things need decision, though:

• Is "caravan" good enough US translation in order not to be confused with static caravan? Or should it be changed or some string translation hints be added (and where?) - see Camping site quests #4213 (comment)
• should the camp_type quest be enabled or disabled by default? There have been arguments for both, so it's a matter of commenting or uncommenting the line - see Camping site quests #4213 (review)

[mnalis]

recently I was talking with friends and it turns out that in some regions even "is this camping site paid" maybe would be a viable quest

In my limited experience of near-to-Croatia parts of Europe it does seem spammy (see #4198 (comment)), but I guess it might differ worldwide. If camp fee quest would be useful in some countries (and backcountry answer as currently implemented is insufficient), I think another issue/PR should be opened, as this one if overstuffed already (probably would need some research where it would not be spammy).

[peternewman]

(and backcountry answer as currently implemented is insufficient), I think another issue/PR should be opened, as this one if overstuffed already

I strongly feel this PR shouldn't be merged with the backcountry answer in its current state; leaving a note when required occasionally would be better than the current other answer which can result in incorrect tagging. Looking at taginfo, more than a quarter of backcountry=yes are also tagged with tents=yes, so setting the opposite for one when we tag the other seems crazy to me:
https://taginfo.openstreetmap.org/tags/backcountry=yes#combinations

[mnalis]

I strongly feel this PR shouldn't be merged with the backcountry answer in its current state; leaving a note when required occasionally would be better than the current other answer which can result in incorrect tagging. Looking at taginfo, more than a quarter of backcountry=yes are also tagged with tents=yes, so setting the opposite for one when we tag the other seems crazy to me: https://taginfo.openstreetmap.org/tags/backcountry=yes#combinations

@peternewman I'm not sure of which incorrect tagging are you talking about, can you provide an example of what would be marked incorrectly in which case?
If user chooses Backcountry camping (no facilities) answer, it will be marked only with backcountry=yes tag (and no other quests about facilities will be asked).

I understand that it might be argued that some additional tags might be asked for backcountry camps too; but surely there is no incorrect tagging if tourism=camp_site gets tagged only with additional backcountry=yes?

Or did I misunderstand your point? You may try this debug .apk if you wish to quickly check what the quest actually tags on which answer and/or wish to provide a screenshot of the problem.

[peternewman]

Some suggestions to clarify the backcountry behaviour

[peternewman]

@peternewman I'm not sure of which incorrect tagging are you talking about, can you provide an example of what would be marked incorrectly in which case? If user chooses Backcountry camping (no facilities) answer, it will be marked only with backcountry=yes tag

Apologies, I'd got caught out by your BACKCOUNTRY(false, false),, not checked the other code and assumed it was going to tag tents=no too. I've added some code suggestions for how to improve the clarity of that a lot (IMHO), including the all-important comment, and a fairly simple extension for how to potentially make it even better and remove the gotcha false values entirely.

(and no other quests about facilities will be asked).

This bit is currently untrue looking at the quest filters, you'll still be asked about water, showers and power even if its tagged as backcountry (where they are less likely and its possibly spammy).

[mnalis]

Apologies, I'd got caught out by your BACKCOUNTRY(false, false),, not checked the other code and assumed it was going to tag tents=no too. I've added some code suggestions for how to improve the clarity of that a lot (IMHO), including the all-important comment, and a fairly simple extension for how to potentially make it even better and remove the gotcha false values entirely.

Thanks, I've added you code-readability improvements!

This bit is currently untrue looking at the quest filters, you'll still be asked about water, showers and power even if its tagged as backcountry (where they are less likely and its possibly spammy).

Ah yes. I've had a mind about disabling quests for them, but after more careful reading of https://wiki.openstreetmap.org/wiki/Key:backcountry I've decided to still ask for them, as it seems at least some of them are still possible (just less likely, i.e. assumed no by default). And as backcountry=yes is only a small subset of camps (according to taginfo) and camps are relatively rare themselves, I do not think continuing to ask for them would be too spammy. But if there is consensus to disable some of them for backcountry=yes, I'm not against.

[westnordost]

Nice, clean implementation. I have nothing else to add other than the tweaks on the wordings. I will do the icons after merging.

[matkoniecz]

From not-a-native-speaker: I would have no idea what "RV" is, even with context.

[westnordost]

Okay

[riQQ]

Also as a non-native speaker: RV is clear for me.

[westnordost]

🤷 I changed it to "motorhomes, travel trailers, ..." or something