prevent really unclear level quests with no detected object type #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matkoniecz
referenced
this pull request
Aug 16, 2023
require object having known name or known object type otherwise mapper has no chance to answer question similar to say 14f0040 prompted by https://www.openstreetmap.org/node/6213197233
|
This has been discussed in particular in #4448 (comment) onwards |
|
So, it looks like the chosen solution should rather mimic what a4c6d32 did for consistency. |
|
That may fail in unusual cases, say |
|
Yeah |
skip vast majority of objects without known name or known object type in such cases mapper has no chance to answer question prompted by https://www.openstreetmap.org/node/6213197233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require object having known name or known object type otherwise mapper has no chance to answer question
similar to say 14f0040
prompted by https://www.openstreetmap.org/node/6213197233
Without this change the level number quest may be asked without giving any info whatsoever what it is being asked about.
Note that it will NOT block objects of known type with no name tags.
Similar filtering is used already by opening hours quest.