fix: sample projects, remove unused properties #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kryptos-FR
reviewed
Mar 31, 2024
samples/Audio/SimpleAudio/SimpleAudio.Windows/SimpleAudio.Windows.csproj
Outdated
Show resolved
Hide resolved
samples/Audio/SimpleAudio/SimpleAudio.Windows/SimpleAudio.Windows.csproj
Show resolved
Hide resolved
samples/Audio/SimpleAudio/SimpleAudio.Windows/SimpleAudio.Windows.csproj
Show resolved
Hide resolved
Jklawreszuk
force-pushed
the
samples-fix
branch
2 times, most recently
from
68d4dee
to
b6411b0
Compare
Kryptos-FR
reviewed
Aug 24, 2024
| <ApplicationIcon>Resources\GameIcon.ico</ApplicationIcon> | ||
| <OutputType>WinExe</OutputType> | ||
| <RootNamespace>SimpleAudio</RootNamespace> | ||
| <OutputPath>..\Bin\Windows\$(Configuration)\</OutputPath> | ||
| <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath> | ||
| <DefineConstants>STRIDE_PLATFORM_DESKTOP</DefineConstants> |
There was a problem hiding this comment.
It looks like the TRACE constants was also defined in all configurations. Not sure what it is used for though.
There was a problem hiding this comment.
It seems to be useful when we want to use the Trace class and/or print out trace logs. I don't think it is a useful default for game samples. So I'm ok with leaving it out.
Reference: https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.trace
Kryptos-FR
approved these changes
Aug 24, 2024
|
Thanks for reviewing @Kryptos-FR and @Jklawreszuk for the PR of course |
Eideren
changed the title
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Current samples are using incorrect net8 target framework moniker (windows 7 is no longer supported). I also decided to remove additional bloat from project files
Types of changes
Checklist