[ST] Remove usage of examples from our template classes and add namespaceName parameter #10418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-konge
changed the title
|
/packit test --labels regression |
|
/packit test --labels upgrade |
|
/packit test --labels regression |
2 similar comments
|
/packit test --labels regression |
|
/packit test --labels regression |
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/packit test --labels regression |
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/packit test --labels regression |
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run regression |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
Aug 9, 2024
…ame parameter Signed-off-by: Lukas Kral <lukywill16@gmail.com> fixups Signed-off-by: Lukas Kral <lukywill16@gmail.com> move the ZK related method from KRaft method 🤦 Signed-off-by: Lukas Kral <lukywill16@gmail.com> fixups Signed-off-by: Lukas Kral <lukywill16@gmail.com> another fixups Signed-off-by: Lukas Kral <lukywill16@gmail.com> fix rolling update 🤦 Signed-off-by: Lukas Kral <lukywill16@gmail.com> fix metrics Signed-off-by: Lukas Kral <lukywill16@gmail.com> changes after rebase Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
im-konge
force-pushed
the
remove-examples-from-templates
branch
from
46cb6d7
to
66b889f
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/packit test --labels regression |
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
henryZrncik
approved these changes
Aug 12, 2024
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaRebalanceTemplates.java
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/bridge/HttpBridgeTlsST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/bridge/HttpBridgeTlsST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/bridge/HttpBridgeScramShaST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectBuilderST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectBuilderST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectBuilderST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectBuilderST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/operators/CustomResourceStatusST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/security/oauth/OauthPlainST.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
/packit test --labels regression |
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…out it Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
/packit test --labels regression |
Frawless
reviewed
Aug 12, 2024
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaConnectTemplates.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaConnectorTemplates.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaConnectorTemplates.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaMirrorMaker2Templates.java
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaMirrorMaker2Templates.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaRebalanceTemplates.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaTemplates.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaTopicTemplates.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaUserTemplates.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/kafkaUtils/KafkaTopicScalabilityUtils.java
Show resolved
Hide resolved
henryZrncik
reviewed
Aug 13, 2024
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaTopicTemplates.java
Outdated
Show resolved
Hide resolved
Signed-off-by: stiglitz <stiglitz@dev.io>
|
/azp run migration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/packit test --labels regression |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frawless
approved these changes
Aug 15, 2024
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
FG pipeline fails because of issue with Connection refused when doing HTTP request on Keycloak endpoint - it will be fixed as part of #10452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
In this PR I'm removing the usage of examples (from
packaging/examples) from all of our*Templatesclasses.The examples caused us a few issues, especially in upgrade/downgrade scenario where we had to handle which files we should use, for NodePools we had to get the examples from the multi resource YAML file and then edit them.
However, I found out that in most of the cases, we actually replaced almost whole resource in the template classes, keeping just few fields of the configuration from the example files.
Additionally, I wanted to refactor the classes a bit and add
namespaceNameparameter as a first parameter of each of the method, which removes the need of special specification in the.editMetadata.withNamespace().endMetadataconfig block in most of the tests. This is also prerequisite for removal ofsetNamespace()method in ResourceManager, which can cause issues when we don't know what Namespace was actually set for the resource.Checklist