-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ST] Fix Keycloak connection refused issue #10452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/packit test --labels regression |
1 similar comment
/packit test --labels regression |
Merged
1 task
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/packit test --labels regression |
Frawless
approved these changes
Aug 17, 2024
see-quick
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
henryZrncik
approved these changes
Aug 19, 2024
The AZPs are green, there seems to be some issue on TF with OpenTelemetry operator installation (not related to this PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
In our recent pipelines run we started catching issues around connection being refused when we are doing HTTP request to Keycloak API -> right after the wait for Keycloak's Pod readiness. Until now we just tried to do the request once and we expected that it will work (so we didn't think about some race conditions).
It seems that there is some race condition when we are doing the first HTTP request - so the API of Keycloak is somehow not ready yet (right in the moment we are doing the request).
To fix this race condition to happen, I added
waitFor
that tries to do the HTTP request few times in case that there is some connection refused error or something like that.Additionally, this PR adds log collection for the Keycloak related Pods, which was missing all the time (so the actual debug was impossible, because from the information we had it looked like there was no issue at all).
Checklist