Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Fix Keycloak connection refused issue #10452

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Aug 14, 2024

Type of change

  • Bugfix

Description

In our recent pipelines run we started catching issues around connection being refused when we are doing HTTP request to Keycloak API -> right after the wait for Keycloak's Pod readiness. Until now we just tried to do the request once and we expected that it will work (so we didn't think about some race conditions).
It seems that there is some race condition when we are doing the first HTTP request - so the API of Keycloak is somehow not ready yet (right in the moment we are doing the request).

To fix this race condition to happen, I added waitFor that tries to do the HTTP request few times in case that there is some connection refused error or something like that.

Additionally, this PR adds log collection for the Keycloak related Pods, which was missing all the time (so the actual debug was impossible, because from the information we had it looked like there was no issue at all).

Checklist

  • Make sure all tests pass

@im-konge
Copy link
Member Author

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

/packit test --labels regression

1 similar comment
@im-konge
Copy link
Member Author

/packit test --labels regression

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge
Copy link
Member Author

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

/packit test --labels regression

@im-konge im-konge marked this pull request as ready for review August 17, 2024 14:14
@im-konge im-konge requested a review from a team August 17, 2024 14:20
@im-konge im-konge self-assigned this Aug 17, 2024
@im-konge im-konge added this to the 0.43.0 milestone Aug 17, 2024
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@im-konge
Copy link
Member Author

im-konge commented Aug 19, 2024

The AZPs are green, there seems to be some issue on TF with OpenTelemetry operator installation (not related to this PR).

@im-konge im-konge merged commit f8c4bc1 into strimzi:main Aug 19, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants