Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint error related to bouncy castle on 14.0.0 #2268

Closed
romainpiel opened this issue Mar 9, 2020 · 1 comment · Fixed by #2271
Closed

Lint error related to bouncy castle on 14.0.0 #2268

romainpiel opened this issue Mar 9, 2020 · 1 comment · Fixed by #2271
Assignees
@mshafrir-stripe
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@romainpiel
Copy link

romainpiel commented Mar 9, 2020 •
edited
Loading

Summary

Lint throws an error on Stripe 14.0.0+:
image

Code to reproduce

I just included a version of the dependency in our build.gradle.

Android version

Any

Impacted devices

Any

Installation method

Gradle

SDK version

14.0.0 (also tried 14.1.0)

Other information

I reported a similar issue a while back, I'm not sure if it's related: #1141
@mshafrir-stripe mshafrir-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Mar 9, 2020
@mshafrir-stripe mshafrir-stripe self-assigned this Mar 9, 2020
@mshafrir-stripe
Copy link
Collaborator

@romainpiel Thanks for filing. I was able to reproduce this issue. Based on some investigation, it appears that this class isn't needed [0]. I'll put up a PR to not keep it in Proguard.

[0] justinludwig/jpgpj#3 (comment)

mshafrir-stripe added a commit that referenced this issue Mar 9, 2020
@mshafrir-stripe
Update Proguard rules to remove BouncyCastle class
2e6fb38 
Summary
`X509LDAPCertStoreSpi` uses a J2SE package that isn't available in
Android. This class isn't needed for 3DS2, so don't keep it in Proguard
rules.

Motivation
Fixes #2268

Testing
Ran lint and manually verified
@mshafrir-stripe mshafrir-stripe mentioned this issue Mar 9, 2020
Merged
mshafrir-stripe added a commit that referenced this issue Mar 9, 2020
@mshafrir-stripe
Update Proguard rules to remove BouncyCastle class
6f3f1ac 
Summary
`X509LDAPCertStoreSpi` uses a J2SE package that isn't available in
Android. This class isn't needed for 3DS2, so don't keep it in Proguard
rules.

Motivation
Fixes #2268

Testing
Ran lint and manually verified
mshafrir-stripe added a commit that referenced this issue Mar 9, 2020
@mshafrir-stripe
Update Proguard rules to remove BouncyCastle class (#2271)
f28fa31 
Summary
`X509LDAPCertStoreSpi` uses a J2SE package that isn't available in
Android. This class isn't needed for 3DS2, so don't keep it in Proguard
rules.

Motivation
Fixes #2268

Testing
Ran lint and manually verified
@mshafrir-stripe mshafrir-stripe mentioned this issue Mar 18, 2020
Closed
@K4KYA K4KYA mentioned this issue May 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshafrir-stripe mshafrir-stripe

Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Proguard rules to remove BouncyCastle class stripe/stripe-android
2 participants
@romainpiel @mshafrir-stripe