Update Proguard rules to remove BouncyCastle class #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfave-stripe
approved these changes
Mar 9, 2020
stripe-ci
assigned mshafrir-stripe and unassigned rfave-stripe, chander-stripe and markfi-stripe
Summary `X509LDAPCertStoreSpi` uses a J2SE package that isn't available in Android. This class isn't needed for 3DS2, so don't keep it in Proguard rules. Motivation Fixes #2268 Testing Ran lint and manually verified
mshafrir-stripe
force-pushed
the
proguard-rules
branch
from
2e6fb38 to
6f3f1ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
X509LDAPCertStoreSpiuses a J2SE package that isn't available inAndroid. This class isn't needed for 3DS2, so don't keep it in Proguard
rules.
Motivation
Fixes #2268
Testing
Ran lint and manually verified