Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sources aren't uploaded in the library's AAR. #2426

Closed
colinrtwhite opened this issue Apr 25, 2020 · 3 comments · Fixed by #2429
Closed

Sources aren't uploaded in the library's AAR. #2426

colinrtwhite opened this issue Apr 25, 2020 · 3 comments · Fixed by #2429
Assignees
@mshafrir-stripe
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@colinrtwhite
Copy link

Summary

Code sources aren't being uploaded in the library's AAR. I tested on the latest version com.stripe:stripe-android:14.3.0. If you navigate to the library's sources in Android Studio it shows the decompiled sources.

Installation method

Gradle

SDK version

14.3.0

Let me know if I can provide more info!
@mshafrir-stripe mshafrir-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Apr 26, 2020
@mshafrir-stripe mshafrir-stripe self-assigned this Apr 26, 2020
@mshafrir-stripe
Copy link
Collaborator

@colinrtwhite thanks for filing. What version are upgrading from? Did that version correctly show sources?

I see stripe-android-14.3.0-sources.jar listed under https://oss.sonatype.org/service/local/repositories/releases/content/com/stripe/stripe-android/14.3.0/. I'll need to investigate why it isn't showing up for you when integrating.

@colinrtwhite
Copy link
Author

Hmm I see the sources jar locally as well actually, but they aren't resolved in Android Studio. I'm able to reproduce by importing com.stripe:stripe-android:14.3.0 into a new Android Studio project. If you create a new project are sources visible for you?

@mshafrir-stripe
Copy link
Collaborator

@colinrtwhite I'm able to reproduce the issue and I've found a fix. This should be resolved for the next release. Thanks again for filing.

mshafrir-stripe added a commit that referenced this issue Apr 27, 2020
@mshafrir-stripe
Fix SDK source paths and source publishing
dc195cc 
Summary
See Kotlin's Using Gradle doc [0] for more details.

[0] https://kotlinlang.org/docs/reference/using-gradle.html

Motivation
Fixes #2426

Testing
1. Published to local Maven repository
2. Verified that `sources.jar` and `javadocs.jar` were correctly
   populated
3. Verified that Android Studio correctly shows source code when opening
   a `stripe-android` class
@mshafrir-stripe mshafrir-stripe mentioned this issue Apr 27, 2020
Merged
mshafrir-stripe added a commit that referenced this issue Apr 27, 2020
@mshafrir-stripe
Fix SDK source paths and source publishing (#2429)
37c1728 
Summary
See Kotlin's Using Gradle doc [0] for more details.

[0] https://kotlinlang.org/docs/reference/using-gradle.html

Motivation
Fixes #2426

Testing
1. Published to local Maven repository
2. Verified that `sources.jar` and `javadocs.jar` were correctly
   populated
3. Verified that Android Studio correctly shows source code when opening
   a `stripe-android` class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshafrir-stripe mshafrir-stripe

Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SDK source paths and source publishing stripe/stripe-android
2 participants
@colinrtwhite @mshafrir-stripe