Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK source paths and source publishing #2429

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Fix SDK source paths and source publishing #2429

merged 1 commit into from
Apr 27, 2020

Conversation

mshafrir-stripe
Copy link
Collaborator

Summary

See Kotlin's Using Gradle doc for more details.

Motivation

Fixes #2426

Testing

  1. Published to local Maven repository
  2. Verified that sources.jar and javadocs.jar were correctly
    populated
  3. Verified that Android Studio correctly shows source code when opening
    a stripe-android class

Summary
See Kotlin's Using Gradle doc [0] for more details.

[0] https://kotlinlang.org/docs/reference/using-gradle.html

Motivation
Fixes #2426

Testing
1. Published to local Maven repository
2. Verified that `sources.jar` and `javadocs.jar` were correctly
   populated
3. Verified that Android Studio correctly shows source code when opening
   a `stripe-android` class
Copy link
Contributor

@chander-stripe chander-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tip! gonna try this on terminal sdk as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sources aren't uploaded in the library's AAR.
5 participants