-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Translation Errors #5058
Comments
Hey there! Thanks for writing in. I'm curious how you're changing your device language. I was able to change my device language on my pixel 3a and got the error messages translated. They come from the server for us based on the Locale. I'm wondering if our call with a locale is failing. Could you place a breakpoint here: https://github.com/stripe/stripe-android/blob/master/paymentsheet/src/main/java/com/stripe/android/paymentsheet/repositories/StripeIntentRepository.kt#L56 and let me know if the locale is correct and if the call is coming back? You can use our example app or your own. But..... I'm wondering if you see the issue in our example app too. |
Hi Skyler, Thanks for your answer I see the same issue on your example app : I placed a breakpoint on https://github.com/stripe/stripe-android/blob/master/paymentsheet/src/main/java/com/stripe/android/paymentsheet/repositories/StripeIntentRepository.kt#L56 and got this : Is it because of the region |
Hi @FlorentDambreville 👋 We’ve fixed the issue now. Sorry that it took us so long. Please continue reaching out to us if you experience any other issues. |
Hello 👋 Happy new year 🥳 Thanks for your message Till. We are using Stripe SDK version 20.17.0 (>= 20.16.2 which is suppose to contains the fix if I understand correctly). We can provide dates, customer ID, payment intent id if needed (in private message or via support :)) Regards, |
That’s odd. When I set my device language to French and use Can you share the ID of a payment intent where you have encountered this issue? (It’s safe to share this here, because you’d need the secret key or a client secret to do anything with it.) |
Yeah sure. Here it is : |
Thanks, that’s very helpful. I noticed two things:
I’ll update you once I find out more. |
Hello again, Do you have any updates on the subject ? This issue is pretty critical for us. |
Hi @FlorentDambreville! Sorry that this has taken a while. I actually began looking into it again this morning. I wanted to see if we could make any server-side changes for the error message localization, but it doesn’t seem that easy. Therefore, like our iOS SDK, I’m adding client-side mapping for any errors that we receive in the authentication flows. I’ll aim to have this merged this week, so that it’s included in next week’s release. |
Awesome thanks.🙇 |
It’s merged now, so I’m closing this issue. Thanks again for notifying us that the issue persisted and helping us fix it 🙏 Definitely reach out again if you notice any other issues. |
Ticket reopened because we recently noticed that we still have the translation issue in french :
Other cases seems to be well translated, but considering our users frequently face this particular case, we'll be glad if you can fix this. |
Hi @ElodieCatArr 👋 Thanks for commenting and sorry about the translation issues. Is this happening on the latest version? When trying it in our example app with |
We are using your SDK v20.31.0 The main issue is your change of error message from "insufficient funds" to "your card was declined." I recommend reverting to the "insufficient funds" message or considering a more descriptive alternative. This provides clarity and improves user experience during payment processing. You can test it with your testing usecase |
Summary
There are several missing translations for error message that we need.
It is critical for us because our user often have payment issues.
Android version
Reproduced on android version 10, 11 & 12
Impacted devices
All our test devices : Samsung S20 Ultra 5G, Huawei P9 Lite and more...
Installation method
Maven dependency
Dependency Versions
kotlin:
1.6.21
stripe-android:
20.4.0
Android Gradle Plugin:
7.2.0
Gradle:
7.2.4
SDK classes
PaymentSheet
The text was updated successfully, but these errors were encountered: