[connect] Update SDK API then Example app as needed #10330

lng-stripe · 2025-03-06T17:25:11Z

Summary

Update the Connect SDK API and Example app following API review. Some API behavior was removed, so the Example app UX needed to be updated as appropriate:

Remove XML view setting
Remove example component Activities since we're only presenting DialogFragments (for now)
Apply edge-to-edge setting to the MainActivity due to the above.
Prompt to restart the app for edge-to-edge changes to take effect due to the above.

The diff is big, but it's mostly moving and deleting code. See inline comments.

Motivation

https://jira.corp.stripe.com/browse/CAX-3739
https://jira.corp.stripe.com/browse/CAX-3803

Testing

Added tests
Modified tests
Manually verified

Screenshots

Screen.Recording.2025-03-06.at.12.26.39.PM-compressed.mov

github-actions · 2025-03-06T17:31:00Z

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │   0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │   0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.1 KiB │   6.1 KiB │   0 B │   5.9 KiB │   5.9 KiB │  0 B 
    other │  95.1 KiB │  95.1 KiB │ +11 B │ 182.2 KiB │ 182.2 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +11 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20119 │ 20119 │ 0 (+0 -0) 
   types │  6224 │  6224 │ 0 (+0 -0) 
 classes │  5018 │  5018 │ 0 (+0 -0) 
 methods │ 30008 │ 30008 │ 0 (+0 -0) 
  fields │ 17362 │ 17362 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3643 │ 3643 │  0

APK

    compressed    │  uncompressed   │                                           
──────────┬───────┼──────────┬──────┤                                           
 size     │ diff  │ size     │ diff │ path                                      
──────────┼───────┼──────────┼──────┼───────────────────────────────────────────
 28.9 KiB │ +10 B │   64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │  +2 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    271 B │  -1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼───────┼──────────┼──────┼───────────────────────────────────────────
 30.4 KiB │ +11 B │ 65.3 KiB │  0 B │ (total)

lng-stripe · 2025-03-06T17:32:17Z

...src/main/java/com/stripe/android/connect/example/ui/componentpicker/ComponentPickerScreen.kt

@@ -115,7 +111,6 @@ fun ComponentPickerContent(
                        activity = context,
                        title = "Account Onboarding",
                        props = onboardingSettings.toProps(),
-                        cacheKey = "AccountOnboardingExample"


👀 cacheKey is unnecessary for Controllers since there can only be one.

lng-stripe · 2025-03-06T17:33:36Z

...ple/src/main/java/com/stripe/android/connect/example/ui/settings/PresentationSettingsView.kt

-        actions = {
-            IconButton(
-                onClick = {
-                    onSave(


👀 Removed Save button in favor of save-on-change, since the UX is better with the toast.

lng-stripe · 2025-03-06T18:13:03Z

connect/src/main/java/com/stripe/android/connect/AccountOnboardingController.kt

-    cacheKey: String? = null,
-) : StripeComponentController<AccountOnboardingListener> by StripeComponentControllerImpl(
-    cls = AccountOnboardingDialogFragment::class.java,
+) : StripeComponentController<AccountOnboardingListener, AccountOnboardingProps>(
+    dfClass = AccountOnboardingDialogFragment::class.java,


👀

As mentioned above, cacheKey is not necessary for Controllers since there can only be one DialogFragment per component type.

StripeComponentController was converted to an abstract class with its implementation was migrated from StripeComponentControllerImpl

lng-stripe · 2025-03-06T18:13:39Z

connect/src/main/java/com/stripe/android/connect/EmbeddedComponentManager.kt

@@ -89,7 +86,7 @@ class EmbeddedComponentManager(
     * @param cacheKey Key to use for caching the internal WebView across configuration changes.
     */
    @PrivateBetaConnectSDK
-    fun createAccountOnboardingView(
+    internal fun createAccountOnboardingView(


👀 API change

lng-stripe · 2025-03-06T18:14:40Z

connect/src/main/java/com/stripe/android/connect/StripeComponentController.kt


 /**
 * Controller for a full screen component.
 */
 @PrivateBetaConnectSDK
 @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
-interface StripeComponentController<Listener : StripeEmbeddedComponentListener> {
+abstract class StripeComponentController<Listener, Props> internal constructor(


👀 As mentioned earlier, this was changed to an abstract class with an internal constructor. Its implementation was merged in from StripeComponentControllerImpl, which was deleted. There are no logic changes.

lng-stripe · 2025-03-06T18:16:14Z

connect/src/main/java/com/stripe/android/connect/StripeComponentDialogFragment.kt

+/**
+ * A full-screen DialogFragment that displays a full-screen component.
+ *
+ * The implementation to make this all work *well* is quite tricky and deserves some explanation.


👀 These implementation notes are from StripeComponentControllerImpl. I didn't put this in StripeComponentController due to previous feedback to reduce its visibility to users.

amk-stripe

Can you please split this up into multiple PRs? This makes review so much easier and is also much better for commit and PR history

I'm thinking that since there are 4 bullet points of things that happened here, this should definitely be multiple PRs. And the API changes could at least be their own PR with a link to the updated API review so I can see some context on the changes.

Thank you!!

lng-stripe · 2025-03-06T22:00:05Z

Can you please split this up into multiple PRs?

Will do, but I will flag that with recent CI flakiness this could potentially be really painful.

lng-stripe added 9 commits March 6, 2025 10:09

disable xml views

3e399b4

only enable Account Onboarding in example

ccc35ae

rm cacheKey from API for full screen

e3ff5f5

convert StripeComponentController to abstract class

f6e5205

hide create*View() behind internal

05380fe

rm Payouts and View API usage

ae0cf46

save presentation settings on change

20dd2fa

not full screen

9ee7459

lint

cde2c57

cleanup

3486692

lng-stripe commented Mar 6, 2025

View reviewed changes

lng-stripe marked this pull request as ready for review March 6, 2025 18:17

lng-stripe requested review from a team as code owners March 6, 2025 18:17

lng-stripe requested a review from amk-stripe March 6, 2025 20:49

lng-stripe assigned amk-stripe Mar 6, 2025

amk-stripe reviewed Mar 6, 2025

View reviewed changes

This was referenced Mar 6, 2025

[connect-example] Remove "Use XML views" setting #10338

Open

[connect-example] Remove example component Activities #10339

Draft

[connect-example] Save edge-to-edge setting on change and prompt restart #10340

Draft

[connect] Update APIs post-review #10341

Draft

lng-stripe closed this Mar 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[connect] Update SDK API then Example app as needed #10330

[connect] Update SDK API then Example app as needed #10330

lng-stripe commented Mar 6, 2025 •

edited

Loading

github-actions bot commented Mar 6, 2025 •

edited

Loading

lng-stripe Mar 6, 2025

lng-stripe Mar 6, 2025

lng-stripe Mar 6, 2025

lng-stripe Mar 6, 2025

lng-stripe Mar 6, 2025

lng-stripe Mar 6, 2025

amk-stripe left a comment

lng-stripe commented Mar 6, 2025

[connect] Update SDK API then Example app as needed #10330

[connect] Update SDK API then Example app as needed #10330

Conversation

lng-stripe commented Mar 6, 2025 • edited Loading

Summary

Motivation

Testing

Screenshots

github-actions bot commented Mar 6, 2025 • edited Loading

lng-stripe Mar 6, 2025

Choose a reason for hiding this comment

lng-stripe Mar 6, 2025

Choose a reason for hiding this comment

lng-stripe Mar 6, 2025

Choose a reason for hiding this comment

lng-stripe Mar 6, 2025

Choose a reason for hiding this comment

lng-stripe Mar 6, 2025

Choose a reason for hiding this comment

lng-stripe Mar 6, 2025

Choose a reason for hiding this comment

amk-stripe left a comment

Choose a reason for hiding this comment

lng-stripe commented Mar 6, 2025

lng-stripe commented Mar 6, 2025 •

edited

Loading

github-actions bot commented Mar 6, 2025 •

edited

Loading