Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connect-example] Remove "Use XML views" setting #10338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lng-stripe
Copy link
Contributor

Summary

As the title says.

Motivation

https://jira.corp.stripe.com/browse/CAX-3803
#10330 (review)

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Screen.Recording.2025-03-06.at.5.08.55.PM.mov

@lng-stripe lng-stripe requested review from a team as code owners March 6, 2025 22:10
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │   0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │   0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.1 KiB │   6.1 KiB │   0 B │   5.9 KiB │   5.9 KiB │  0 B 
    other │  95.1 KiB │  95.1 KiB │ +13 B │ 182.2 KiB │ 182.2 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +13 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20126 │ 20126 │ 0 (+0 -0) 
   types │  6228 │  6228 │ 0 (+0 -0) 
 classes │  5022 │  5022 │ 0 (+0 -0) 
 methods │ 30024 │ 30024 │ 0 (+0 -0) 
  fields │ 17379 │ 17379 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3643 │ 3643 │  0
APK
    compressed    │   uncompressed   │                        
──────────┬───────┼───────────┬──────┤                        
 size     │ diff  │ size      │ diff │ path                   
──────────┼───────┼───────────┼──────┼────────────────────────
 28.9 KiB │ +10 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.7 KiB │  +3 B │  63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼───────┼───────────┼──────┼────────────────────────
 54.6 KiB │ +13 B │ 127.9 KiB │  0 B │ (total)

@lng-stripe lng-stripe closed this Mar 6, 2025
@lng-stripe lng-stripe reopened this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants