Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Google Pay option in Basic Integration #1995

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

mshafrir-stripe
Copy link
Collaborator

To enable Google Pay as a payment method option:

If using PaymentSession (i.e. Basic Integration),

PaymentSessionConfig.Builder()
    // other settings
    .setShouldShowGooglePay(true)
    .build()

or, if using PaymentMethodsActivity directly,

PaymentMethodsActivityStarter.Args.Builder()
    // other settings
    .setShouldShowGooglePay(true)
    .build()

To determine if the user selected the Google Pay
option:

If using PaymentSession, check PaymentSessionData.useGooglePay; or, if using PaymentMethodsActivity directly, check PaymentMethodsActivityStarter.Result#useGooglePay.

ANDROID-457

google_pay

To enable Google Pay as a payment method option:

If using `PaymentSession` (i.e. Basic Integration)
```
PaymentSessionConfig.Builder()
    // other settings
    .setShouldShowGooglePay(true)
    .build()
```

or, if using `PaymentMethodsActivity` directly
```
PaymentMethodsActivityStarter.Args.Builder()
    // other settings
    .setShouldShowGooglePay(true)
    .build()
```

To determine if the user selected the Google Pay
option:

If using `PaymentSession`, check `PaymentSessionData.useGooglePay`;
or, if using `PaymentMethodsActivity` directly,
`PaymentMethodsActivityStarter.Result#useGooglePay`.

ANDROID-457
Copy link
Contributor

@csabol-stripe csabol-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! A simpler update than I expected :)

@mshafrir-stripe
Copy link
Collaborator Author

@csabol-stripe I did as much work as I can to enable this prior to the PR (those changes are already committed), but actually enabling the feature is a breaking change

@mshafrir-stripe mshafrir-stripe merged commit c4c2d20 into master Dec 20, 2019
@mshafrir-stripe mshafrir-stripe deleted the enable-google-pay branch December 20, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants