-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google pay #880
Google pay #880
Conversation
…ring of apple pay sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for posting this PR. Can you fix CI failures? FYI, we'll need to investigate this PR from a product perspective before we can sign off on it.
example/src/main/java/com/stripe/example/activity/CustomerSessionActivity.java
Outdated
Show resolved
Hide resolved
example/src/main/java/com/stripe/example/activity/CustomerSessionActivity.java
Outdated
Show resolved
Hide resolved
example/src/main/java/com/stripe/example/activity/CustomerSessionActivity.java
Outdated
Show resolved
Hide resolved
stripe/src/main/java/com/stripe/android/view/GooglePayView.java
Outdated
Show resolved
Hide resolved
stripe/src/main/java/com/stripe/android/view/GooglePayView.java
Outdated
Show resolved
Hide resolved
example/src/main/java/com/stripe/example/activity/CustomerSessionActivity.java
Outdated
Show resolved
Hide resolved
stripe/src/main/java/com/stripe/android/view/GooglePayView.java
Outdated
Show resolved
Hide resolved
Hi Man,
hope it's better. now, two notes:
Cheers, |
Hi Any update? |
@galkahana again, thank you for posting this PR. I haven't had time to prioritize reviewing this PR. We also updated our UI components to migrate to the Payment Methods API, so it appears that this PR will also need to be updated to support those changes. Regarding the change to the deploy script, you can comment out that line if you need to for testing purposes. cc @siilats |
@galkahana apologies for keeping this PR open for so long. We are in the process of refactoring our standard integration components. I'll look into adding Google Pay as an option once we're done with that. |
@galkahana @siilats FYI I posted a PR for adding Google Pay support to Basic Integration: #1995 |
Summary
I added google pay to payment methods form. Note that only to the payment activity. I didn't complement with the rest of the payment session. This is because my workflow required only the activity.
Implementation is similar to how apple pay is done in IOS. meaning, an exclusive payment method and filtering of the sources.
Motivation
I really wanted google pay. really.
Testing
Sure. I added the google pay option to the example project, customer session.