Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google pay #880

Closed
wants to merge 14 commits into from
Closed

Google pay #880

wants to merge 14 commits into from

Conversation

galkahana
Copy link
Contributor

Summary

I added google pay to payment methods form. Note that only to the payment activity. I didn't complement with the rest of the payment session. This is because my workflow required only the activity.

Implementation is similar to how apple pay is done in IOS. meaning, an exclusive payment method and filtering of the sources.

Motivation

I really wanted google pay. really.

Testing

Sure. I added the google pay option to the example project, customer session.

Copy link
Collaborator

@mshafrir-stripe mshafrir-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for posting this PR. Can you fix CI failures? FYI, we'll need to investigate this PR from a product perspective before we can sign off on it.

@galkahana
Copy link
Contributor Author

Hi Man,
update on this PR.

  • corrected per your requests
  • ci now work

hope it's better.

now, two notes:

  1. A late addition to the deploy.gradle causes an error when trying to build jitpack build based on master. (see here for the log). donnow if it's intended, but thing is that till this change it was possible to jitpack and so enjoy latest corrections that's not released yet (I kinda have to). commenting out the gpg part solves the problem, but i guess that's not what you had in mind.
  2. I'm thinking to add also a delete functionality to the cards list in payment methods, imitating the behavior implemented in iOS SDK. Say I do, will you be interested in a PR? do i extend this PR or create a new one?

Cheers,
Gal.

@siilats
Copy link

siilats commented May 22, 2019

Hi Any update?

@mshafrir-stripe
Copy link
Collaborator

@galkahana again, thank you for posting this PR. I haven't had time to prioritize reviewing this PR. We also updated our UI components to migrate to the Payment Methods API, so it appears that this PR will also need to be updated to support those changes.

Regarding the change to the deploy script, you can comment out that line if you need to for testing purposes.

cc @siilats

@mshafrir-stripe
Copy link
Collaborator

@galkahana apologies for keeping this PR open for so long. We are in the process of refactoring our standard integration components. I'll look into adding Google Pay as an option once we're done with that.

@mshafrir-stripe
Copy link
Collaborator

@galkahana @siilats FYI I posted a PR for adding Google Pay support to Basic Integration: #1995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants