Remove StripeSSLSocketFactory #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation The Stripe API requires TLS 1.2 [0]. Android API 20+ have TLS 1.2 enabled by default [1]. Now that `minSdkVersion` is `21`, `StripeSSLSocketFactory` is no longer necessary. [0] https://stripe.com/blog/completing-tls-upgrade [1] https://developer.android.com/reference/javax/net/ssl/SSLSocket#default-configuration-for-different-android-versions Testing Verifiy on API 21 device
smaskell-stripe
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Stripe API requires TLS 1.2 [0].
Android API 20+ have TLS 1.2 enabled by default [1].
Now that
minSdkVersionis21,StripeSSLSocketFactoryisno longer necessary.
[0] https://stripe.com/blog/completing-tls-upgrade
[1] https://developer.android.com/reference/javax/net/ssl/SSLSocket#default-configuration-for-different-android-versions
Testing
Verified on API 21 device