Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StripeSSLSocketFactory #2599

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Remove StripeSSLSocketFactory #2599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions stripe/src/main/java/com/stripe/android/ConnectionFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ internal interface ConnectionFactory {
connectTimeout = CONNECT_TIMEOUT
readTimeout = READ_TIMEOUT
useCaches = false
sslSocketFactory = SSL_SOCKET_FACTORY
requestMethod = request.method.code

request.headers.forEach { (key, value) ->
Expand All @@ -41,7 +40,6 @@ internal interface ConnectionFactory {
}

private companion object {
private val SSL_SOCKET_FACTORY = StripeSSLSocketFactory()
private val CONNECT_TIMEOUT = TimeUnit.SECONDS.toMillis(30).toInt()
private val READ_TIMEOUT = TimeUnit.SECONDS.toMillis(80).toInt()

Expand Down
2 changes: 1 addition & 1 deletion stripe/src/main/java/com/stripe/android/StripePaymentController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ internal class StripePaymentController internal constructor(
private val config: PaymentAuthConfig =
PaymentAuthConfig.get(),
private val threeDs2Service: StripeThreeDs2Service =
StripeThreeDs2ServiceImpl(context, StripeSSLSocketFactory(), enableLogging),
StripeThreeDs2ServiceImpl(context, null, enableLogging),
private val analyticsRequestExecutor: AnalyticsRequestExecutor =
AnalyticsRequestExecutor.Default(Logger.getInstance(enableLogging)),
private val analyticsDataFactory: AnalyticsDataFactory =
Expand Down
104 changes: 0 additions & 104 deletions stripe/src/main/java/com/stripe/android/StripeSSLSocketFactory.kt
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions stripe/src/test/java/com/stripe/android/StripeSSLSocketFactoryTest.kt
View file
Open in desktop

This file was deleted.