Card-scanning in PaymentSheet #4804
Conversation
…rm field values of it's elements. This simplifies the form quite a bit!
…that we don't have to iterate through section element fields to get the form field values.
payments-ui-core/src/main/java/com/stripe/android/ui/core/StripeCardScanProxy.kt
Show resolved
Hide resolved
payments-ui-core/src/main/java/com/stripe/android/ui/core/StripeCardScanProxy.kt
Show resolved
Hide resolved
payments-ui-core/src/main/java/com/stripe/android/ui/core/cardscan/CardScanActivity.kt
Show resolved
Hide resolved
...nts-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardDetailsSectionElementUI.kt
Show resolved
Hide resolved
| val cardScanLauncher = | ||
| rememberLauncherForActivityResult(ActivityResultContracts.StartActivityForResult()) { | ||
| it.data?.let { | ||
| controller.cardDetailsElement.controller.numberElement.controller.onCardScanResult( |
There was a problem hiding this comment.
This line feels a little weird. Maybe this logic should be moved to your controller class?
There was a problem hiding this comment.
I'm not sure how I would move this logic - the rememberLauncherForActivityResult method is a Composable method, and I'm calling the onCardScanResult function in the controller from the callback
There was a problem hiding this comment.
oh fair enough. You can put a @composable method in the controller if you want. The bit that I'm feeling weird about is the controller.cardDetailsElement.controller.numberElement.controller.onCardScanResult but I think that's required weirdness right? We couldn't hide that away in the controller? I like not having a ton of logic in the compose views and making them as dumb as possible.
There was a problem hiding this comment.
An alternative would be to add a function in the CardDetailsSectionElementController that then calls the cardDetailsElement.controller.numberElement.controller.onCardScanResult() function
paymentsheet/src/main/java/com/stripe/android/paymentsheet/forms/FormUI.kt
Outdated
Show resolved
Hide resolved
payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardNumberController.kt
Show resolved
Hide resolved
payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardNumberController.kt
Show resolved
Hide resolved
...nts-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardDetailsSectionElementUI.kt
Outdated
Show resolved
Hide resolved
...nts-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardDetailsSectionElementUI.kt
Outdated
Show resolved
Hide resolved
...nts-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardDetailsSectionElementUI.kt
Outdated
Show resolved
Hide resolved
...nts-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardDetailsSectionElementUI.kt
Outdated
Show resolved
Hide resolved
|
Can you do this with a quick test when "Don't keep activities is turned on". |
|
Can we use the built in android camera resource (android.R.drawable.ic_menu_camera)? |
...nts-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardDetailsSectionElementUI.kt
Outdated
Show resolved
Hide resolved
| @@ -5,4 +5,7 @@ | |||
| --> | |||
| <!-- Card details section title for card form entry --> | |||
| <string name="card_information" tools:ignore="ExtraTranslation">Card information</string> | |||
|
|
|||
| <!-- Scan card button --> | |||
| <string name="scan_card" tools:ignore="ExtraTranslation">Scan card</string> | |||
There was a problem hiding this comment.
I am looking up the translated string in localize and adding it.
There was a problem hiding this comment.
ok, got it in localize, and it will update the next time we run the script. Best to wait until this other PR is merged to run the localize script again. #4892
Summary
Add the ability for customers to enter credit card details into PaymentSheet by pointing their device’s camera at their physical card instead of manually typing them in.
Motivation
Card-scanning is one of the top requests from developers and already exists in iOS, but has not yet been implemented in the Android SDK.
Testing
Screenshots