Code

Card-scanning in PaymentSheet#4804

Code

Merged

epan-stripe merged 153 commits intomasterstripe/stripe-android:masterfrom elena/cardscanningstripe/stripe-android:elena/cardscanningCopy head branch name to clipboardApr 25, 2022

+548-23

Commits

Commits on Aug 9, 2021

• [WIP]

  michelleb-stripe

  committed
  c5ef5ec

Commits on Aug 12, 2021

• Display and receive input for Credit Card number and CVC.

  michelleb-stripe

  committed
  0c95106

• Add in the credit billing fields, need hidden visibility to work on address fields.

  michelleb-stripe

  committed
  75e54d1

• Merge with master.

  michelleb-stripe

  committed
  cd4ff51

• Billing code now shows the correct fields.

  michelleb-stripe

  committed
  da41eb0

• Billing now added to the credit element.

  michelleb-stripe

  committed
  a9a04ac

• Credit card number length verification corrected.

  michelleb-stripe

  committed
  2ceac10

Commits on Aug 17, 2021

• Refactor Elements so each element (including sections) provide the form field values of it's elements. This simplifies the form quite a bit!

  michelleb-stripe

  committed
  e35e2c7

Commits on Aug 18, 2021

• Add in the expiration date functionality.

  michelleb-stripe

  committed
  f897f12

Commits on Aug 21, 2021

• Merge branch 'master' into michelleb/credit-card-compose

  michelleb-stripe

  committed
  53661e1

• Refactor so that each element returns a flow of FormFieldEntries, so that we don't have to iterate through section element fields to get the form field values.

  michelleb-stripe

  committed
  4f20fb2

Commits on Aug 23, 2021

• Fix unit test

  michelleb-stripe

  committed
  940f304

• Merge with master.

  michelleb-stripe

  committed
  e8fc0ff

• Rename class

  michelleb-stripe

  committed
  7e5ee6a

• More rework

  michelleb-stripe

  committed
  c3d7b28

• Merge with michelleb/refactor-section-form-fields

  michelleb-stripe

  committed
  a61ea99

Commits on Aug 27, 2021

• Get ready for merge with master

  michelleb-stripe

  committed
  b3be29c

Commits on Aug 29, 2021

• Merge with master.

  michelleb-stripe

  committed
  9a258ec

Commits on Sep 20, 2021

• Merge with master

  michelleb-stripe

  committed
  57b617c

Commits on Nov 2, 2021

• Merge with master.

  michelleb-stripe

  committed
  3e60136

• Change from liveData to flow.

  michelleb-stripe

  committed
  4d8ec20

• Merge branch 'michelleb/convert-to-flow' into michelleb/credit-card-compose

  michelleb-stripe

  committed
  591a73e

• Row is working but not expiry date

  michelleb-stripe

  committed
  2aeb3ef

• Make the keypad just numbers.

  michelleb-stripe

  committed
  9161d4f

• Make the keypad just numbers.

  michelleb-stripe

  committed
  0441d0a

• Set the expiration month and date correctly in the formFieldValues

  michelleb-stripe

  committed
  c41ec5d

• Update the focus to visit the CVC

  michelleb-stripe

  committed
  fdad41f

Commits on Nov 3, 2021

• Handle a full text field state.

  michelleb-stripe

  committed
  43c9127

Commits on Nov 4, 2021

• Merge with master

  michelleb-stripe

  committed
  317a841

Commits on Nov 5, 2021

• Unit tests

  michelleb-stripe

  committed
  8e649c8

• ktlintFormat

  michelleb-stripe

  committed
  9ead541

• Format card number based on max pan for card number

  michelleb-stripe

  committed
  939dba9

• Cleanup date util for expiration month

  michelleb-stripe

  committed
  60da73f

• Make the label flowable

  michelleb-stripe

  committed
  f51f90b

Commits on Nov 9, 2021

• Fix internals

  michelleb-stripe

  committed
  fef63b3

• Cleanup

  michelleb-stripe

  committed
  f19cbe2

• Cleanup

  michelleb-stripe

  committed
  07cfa62

• Merge with master

  michelleb-stripe

  committed
  bd5d754

• Fix unit tests

  michelleb-stripe

  committed
  2722977

• ktlintFormat

  michelleb-stripe

  committed
  4bee0c1

• Undos

  michelleb-stripe

  committed
  4b78747

• ktlintFormat

  michelleb-stripe

  committed
  9242d80

Commits on Nov 11, 2021

• Merge with master

  michelleb-stripe

  committed
  b1cd5b0

Commits on Nov 17, 2021

• Merge remote-tracking branch 'origin/master' into michelleb/credit-card-compose

  michelleb-stripe

  committed
  239273d

Commits on Nov 29, 2021

• Merge with master

  michelleb-stripe

  committed
  8eb4204

Commits on Dec 2, 2021

• Merge with master

  michelleb-stripe

  committed
  40fe6c0

Commits on Dec 5, 2021

• Ignore tests that cause other failures

  michelleb-stripe

  committed
  adaed05

Commits on Feb 3, 2022

• Merge branch 'master' into michelleb/credit-card-compose

  michelleb-stripe

  committed
  667bd39

Commits on Feb 4, 2022

• Working on the merge.

  michelleb-stripe

  committed
  7c5e474

• Almost building

  michelleb-stripe

  committed
  1eee681

• Get closer to master

  michelleb-stripe

  committed
  7ed49f3

• Update files.

  michelleb-stripe

  committed
  e68a86a

• Iterating

  michelleb-stripe

  committed
  f0fa03a

• Building

  michelleb-stripe

  committed
  5ad3f10

• Fix unit tests

  michelleb-stripe

  committed
  a3c9eae

Commits on Feb 8, 2022

• Cleanup

  michelleb-stripe

  committed
  e2f39c4

• Remove extra comment

  michelleb-stripe

  committed
  57677d8

• Fix failing tests

  epan-stripe

  committed
  6bee0a4

• Fix linting

  epan-stripe

  committed
  2c6e45c

• Fix SaveForFutureUseController.label not showing

  epan-stripe

  committed
  8b5d2ae

• Merge with master

  michelleb-stripe

  committed
  313f52a

• Cleanup

  michelleb-stripe

  committed
  c1e78f7

Commits on Feb 9, 2022

• apiDump

  michelleb-stripe

  committed
  6c9cb94

• Merge with master

  michelleb-stripe

  committed
  508b5ad

• apiDump

  michelleb-stripe

  committed
  33b754a

Commits on Feb 10, 2022

• Fix some failing tests, apiDump, ktlintFormat

  michelleb-stripe

  committed
  7819db6

• Fix remaining failing tests, apiDump, ktlintFormat

  michelleb-stripe

  committed
  b3917f9

• Fix todo

  michelleb-stripe

  committed
  95d8557

• Merge remote-tracking branch 'origin/master' into michelleb/credit-card-compose

  michelleb-stripe

  committed
  7af4ff5

Commits on Feb 11, 2022

• Simplify and add DateConfig tests and cleanup commented out code in TextFieldController.

  michelleb-stripe

  committed
  afd06c9

• Merge with master

  michelleb-stripe

  committed
  98043bd

Commits on Feb 14, 2022

• Merge remote-tracking branch 'origin/master' into michelleb/credit-card-compose

  michelleb-stripe

  committed
  8ca28d2

• ktlintFormat apiDump

  michelleb-stripe

  committed
  9bf81f2

Commits on Feb 15, 2022

• Merge with master

  michelleb-stripe

  committed
  783039a

Commits on Feb 18, 2022

• Add icons to the IBAN, credit card and CVC fields. (#4359)

  michelleb-stripe

  authored
  bf51053

Commits on Feb 22, 2022

• Merge with master

  michelleb-stripe

  committed
  7979d18

• Merge with remote

  michelleb-stripe

  committed
  bd3fb81

Commits on Feb 25, 2022

• Add Card Metadata Service to CardNumberController (#4573)

  Show description for a18c6c2
  

  epan-stripe

  and

  michelleb-stripe

  authored
  a18c6c2

• Don't show cardbrand if there are multiple possibilities

  epan-stripe

  committed
  b4cacba

• Don't show cardbrand if there are multiple possibilities

  epan-stripe

  committed
  06c5d00

• Merge branch 'michelleb/credit-card-compose' of github.com:stripe/stripe-android into michelleb/credit-card-compose

  epan-stripe

  committed
  c179b73

• Merge remote-tracking branch 'origin/master' into michelleb/credit-card-compose

  michelleb-stripe

  committed
  61200f9

• Merge with master

  michelleb-stripe

  committed
  110ecd3

• Material Theme information gathering.

  michelleb-stripe

  committed
  067ea3b

• Revert "Material Theme information gathering."

  Show description for 36913d3
  michelleb-stripe

  committed
  36913d3

Commits on Mar 1, 2022

• Immediately detect invalid card numbers (no brand)

  epan-stripe

  committed
  167b00f

• Fix invalid vs incomplete dateconfig error text

  epan-stripe

  committed
  8701f44

Commits on Mar 2, 2022

• Fix CVC icon and next field focus

  epan-stripe

  committed
  b6fff48

• Fix expiry date accessibility reader

  epan-stripe

  committed
  3ed0104

• Merge branch 'master' into michelleb/credit-card-compose

  epan-stripe

  authored
  7f3d2f2

• Fix merge issues

  epan-stripe

  committed
  d92df95

Commits on Mar 3, 2022

• Add ability to move focus on delete

  jameswoo-stripe

  committed
  e2880f4

• Merge remote-tracking branch 'origin/master' into michelleb/credit-card-compose

  michelleb-stripe

  committed
  81042c0

• Fix dark mode error underline

  epan-stripe

  committed
  219e999

Commits on Mar 4, 2022

• Fix cursor and spacing position in card details

  epan-stripe

  committed
  126de9a

• update icons and colors for future wardrobe work

  skyler-stripe

  committed
  10f4f47

Commits on Mar 8, 2022

• Merge branch 'master' into michelleb/credit-card-compose

  michelleb-stripe

  committed
  da16b49

• Merge branch 'michelleb/credit-card-compose' of github.com:stripe/stripe-android into michelleb/credit-card-compose

  michelleb-stripe

  committed
  0d7f077

• Add card information title

  epan-stripe

  committed
  ba21e4a

Commits on Mar 9, 2022

• Add tests for card number formatting

  epan-stripe

  committed
  0c87580

• Revert "Add tests for card number formatting"

  Show description for 7a60b61
  epan-stripe

  committed
  7a60b61

• Add country list to card and sepa billing spec. (#4669)

  michelleb-stripe

  authored
  d2ff7ba

• Credit Card Address and focus bug fixes (#4665)

  michelleb-stripe

  authored
  55a143b

Commits on Mar 11, 2022

• Fix width of rows (#4676)

  Show description for f111ac0
  epan-stripe

  authored
  f111ac0

• Fix spacing for AMEX and Discover cards (#4672)

  Show description for f3d960b
  epan-stripe

  authored
  f3d960b

Commits on Mar 14, 2022

• Don't show CVC error when CardBrand is unknown (#4681)

  Show description for f8c7ec7
  epan-stripe

  authored
  f8c7ec7

• Stop accessibility talkback reading textfields twice (#4683)

  epan-stripe

  authored
  5fbad06

• Merge with master

  michelleb-stripe

  committed
  c6363f2

• Merge branch 'michelleb/credit-card-compose' of github.com:stripe/stripe-android into michelleb/credit-card-compose

  michelleb-stripe

  committed
  c5c70e5

• ktformat

  michelleb-stripe

  committed
  2ba55b8

• Fix detekt

  michelleb-stripe

  committed
  6fb7a3f

Commits on Mar 15, 2022

• checkbox colors read from theme object now

  skyler-stripe

  committed
  b9095ff

Commits on Mar 18, 2022

• Initial implementation

  epan-stripe

  committed
  74e4e3d

Commits on Mar 23, 2022

• Fix camera icon

  epan-stripe

  committed
  3fe4155

• Move design changes to different branch

  epan-stripe

  committed
  f57c34c

Commits on Mar 24, 2022

• Update camera icon design

  epan-stripe

  committed
  c8b3779

Commits on Mar 29, 2022

• Add string resource for scan card text and remove "test" name

  epan-stripe

  committed
  ecdeafc

• Use actual publishable key

  epan-stripe

  committed
  091965a

Commits on Mar 31, 2022

• Add removeCardScanFragment to StripeCardScanProxy

  epan-stripe

  committed
  13b81ab

• Restart fragment onResume and onPause

  epan-stripe

  committed
  466d186

• Restart fragment onResume and onPause

  epan-stripe

  committed
  e768bc8

• Merge branch 'elena/cardscanning' of github.com:stripe/stripe-android into elena/cardscanning

  epan-stripe

  committed
  e2c7f3b

• Merge branch 'master' of github.com:stripe/stripe-android into elena/cardscanning

  epan-stripe

  committed
  5d9abea

• Merge branch 'master' of github.com:stripe/stripe-android into elena/cardscanning

  epan-stripe

  committed
  3184ef0

• Merge branch 'elena/cardscanning' of github.com:stripe/stripe-android into elena/cardscanning

  epan-stripe

  committed
  fabd5df

• Update to match CardScanSheet changes

  epan-stripe

  committed
  4c69279

• Fix scan card button styling

  epan-stripe

  committed
  da2f828

• Fix scan card button styling

  epan-stripe

  committed
  c973df5

• Merge branch 'elena/cardscanning' of github.com:stripe/stripe-android into elena/cardscanning

  epan-stripe

  committed
  51ed547

• Update CHANGELOG

  epan-stripe

  committed
  f8d4d13

Commits on Apr 1, 2022

• Move CARD_SCAN_PARCELABLE_NAME to companion object

  epan-stripe

  committed
  accd9e8

• Stop passing context in and delete CardDetailsSpec

  epan-stripe

  committed
  0b9ada6

• Make CardScanActivity internal

  epan-stripe

  committed
  fc0d5cf

• Make code segment more functional

  epan-stripe

  committed
  40242b5

• Fix comment

  epan-stripe

  committed
  2cb02da

• Add tests for StripeCardScanProxy

  epan-stripe

  committed
  c329abb

Commits on Apr 4, 2022

• Fix tests

  epan-stripe

  committed
  33cca0b

• Fix tests

  epan-stripe

  committed
  4c3c836

• Merge branch 'elena/cardscanning' of github.com:stripe/stripe-android into elena/cardscanning

  epan-stripe

  committed
  e34a80e

• Stop setting Scan card button font weight

  epan-stripe

  committed
  4ea2f2d

• Merge branch 'master' into elena/cardscanning

  epan-stripe

  authored
  5c75cfa

Commits on Apr 5, 2022

• Merge branch 'master' of github.com:stripe/stripe-android into elena/cardscanning

  epan-stripe

  committed
  c9a9a54

Commits on Apr 6, 2022

• Add context back to TransformSpecToElements

  epan-stripe

  committed
  9fb81f7

• Add CardDetailsSectionController so credit card form values are passed through

  epan-stripe

  committed
  abfbea4

Commits on Apr 15, 2022

• Merge branch 'master' into elena/cardscanning

  epan-stripe

  authored
  9404f8d

Commits on Apr 19, 2022

• Update CardScanActivity package

  epan-stripe

  committed
  194c96b

• Remove context from FormUI

  epan-stripe

  committed
  42daf14

• Add clarifying comment

  epan-stripe

  committed
  a1772de

• Remove unnecessary padding

  epan-stripe

  committed
  8a21c3f

• Create ScanCardButtonUI composable

  epan-stripe

  committed
  88ede33

• Merge branch 'master' of github.com:stripe/stripe-android into elena/cardscanning

  epan-stripe

  committed
  6304213

Commits on Apr 20, 2022

• Move isStripeCardScan object to controller instead of Composable

  epan-stripe

  committed
  1d305cb

• Use material camera icon

  epan-stripe

  committed
  cff7e81