[FC] Gracefully fail when no browsers available #6794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmuvi-stripe
added
the
work-cli
carlosmuvi-stripe
changed the title
carlosmuvi-stripe
added
the
financial-connections
Comment on lines
-154
to
-162
| class ClickLinkAnotherAccount( | ||
| pane: Pane, | ||
| ) : FinancialConnectionsEvent( | ||
| name = "click.link_another_account", | ||
| mapOf( | ||
| "pane" to pane.value, | ||
| ).filterNotNullValues() | ||
| ) | ||
|
|
There was a problem hiding this comment.
Unrelated - unused event (this button does not exist anymore)
carlosmuvi-stripe
requested review from
jaynewstrom-stripe and
vardges-stripe
and removed request for
jaynewstrom-stripe
…7021/android-gracefully-fail-when-no-browsers-available
…7021/android-gracefully-fail-when-no-browsers-available # Conflicts: # CHANGELOG.md
carlosmuvi-stripe
force-pushed
the
carlosmuvi/BANKCON-7021/android-gracefully-fail-when-no-browsers-available
branch
from
c0ed775 to
212616f
Compare
ccen-stripe
approved these changes
Jun 2, 2023
| @@ -0,0 +1,17 @@ | |||
| package com.stripe.android.financialconnections.exception | |||
There was a problem hiding this comment.
Yes! It's not new, it was just on the wrong file and moved it to its own - https://github.com/stripe/stripe-android/pull/6794/files#diff-0d57241060a1753b1c4a26d5c27909e101a54013645f142e528cade0844320a2L15
carlosmuvi-stripe
deleted the
carlosmuvi/BANKCON-7021/android-gracefully-fail-when-no-browsers-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NoActivityFound to handle intentwhen trying to open a web browser an there's none installed on the device.Failcallback notifying the developer, and a toast notifying the user.Motivation
📔 [Android] Gracefully fail when no browsers available
🌐 BANKCON-7021
Testing
Screenshots
toast.webm
Changelog