[FC] Gracefully fail when no browsers available

CHANGELOG.md

@@ -3,7 +3,10 @@
 ## XX.XX.XX - 2023-XX-XX
 ### All SDKs
 * [FIXED][6771](https://github.com/stripe/stripe-android/pull/6771) Fixed the length of phone number field.
+
+# Financial Connections
 * [CHANGED][6789](https://github.com/stripe/stripe-android/pull/6789) Updated Mavericks to 3.0.3.
+* [FIXED][6794](https://github.com/stripe/stripe-android/pull/6794) Gracefully fails when no web browser available.
 
 ## 20.25.3 - 2023-05-23
 

financial-connections/src/main/java/com/stripe/android/financialconnections/FinancialConnectionsSheetViewModel.kt

@@ -12,14 +12,18 @@ import com.stripe.android.financialconnections.FinancialConnectionsSheetState.Au
 import com.stripe.android.financialconnections.FinancialConnectionsSheetViewEffect.FinishWithResult
 import com.stripe.android.financialconnections.FinancialConnectionsSheetViewEffect.OpenAuthFlowWithUrl
 import com.stripe.android.financialconnections.FinancialConnectionsSheetViewEffect.OpenNativeAuthFlow
+import com.stripe.android.financialconnections.analytics.FinancialConnectionsAnalyticsTracker
+import com.stripe.android.financialconnections.analytics.FinancialConnectionsEvent.Error
 import com.stripe.android.financialconnections.analytics.FinancialConnectionsEventReporter
 import com.stripe.android.financialconnections.di.APPLICATION_ID
 import com.stripe.android.financialconnections.di.DaggerFinancialConnectionsSheetComponent
 import com.stripe.android.financialconnections.domain.FetchFinancialConnectionsSession
 import com.stripe.android.financialconnections.domain.FetchFinancialConnectionsSessionForToken
+import com.stripe.android.financialconnections.domain.IsBrowserAvailable
 import com.stripe.android.financialconnections.domain.NativeAuthFlowRouter
 import com.stripe.android.financialconnections.domain.SynchronizeFinancialConnectionsSession
 import com.stripe.android.financialconnections.exception.CustomManualEntryRequiredError
+import com.stripe.android.financialconnections.exception.FinancialConnectionsClientError
 import com.stripe.android.financialconnections.features.manualentry.isCustomManualEntryError
 import com.stripe.android.financialconnections.launcher.FinancialConnectionsSheetActivityArgs.ForData
 import com.stripe.android.financialconnections.launcher.FinancialConnectionsSheetActivityArgs.ForLink
@@ -30,6 +34,7 @@ import com.stripe.android.financialconnections.launcher.FinancialConnectionsShee
 import com.stripe.android.financialconnections.launcher.FinancialConnectionsSheetActivityResult.Failed
 import com.stripe.android.financialconnections.model.FinancialConnectionsSession
 import com.stripe.android.financialconnections.model.FinancialConnectionsSessionManifest
+import com.stripe.android.financialconnections.model.FinancialConnectionsSessionManifest.Pane
 import com.stripe.android.financialconnections.model.SynchronizeSessionResponse
 import com.stripe.android.financialconnections.ui.FinancialConnectionsSheetNativeActivity
 import com.stripe.android.financialconnections.utils.parcelable
@@ -38,6 +43,7 @@ import kotlinx.coroutines.sync.Mutex
 import kotlinx.coroutines.sync.withLock
 import java.lang.IllegalArgumentException
 import java.lang.IllegalStateException
+import java.lang.UnsupportedOperationException
 import javax.inject.Inject
 import javax.inject.Named
 
@@ -49,6 +55,8 @@ internal class FinancialConnectionsSheetViewModel @Inject constructor(
     private val fetchFinancialConnectionsSessionForToken: FetchFinancialConnectionsSessionForToken,
     private val logger: Logger,
     private val eventReporter: FinancialConnectionsEventReporter,
+    private val analyticsTracker: FinancialConnectionsAnalyticsTracker,
+    private val isBrowserAvailable: IsBrowserAvailable,
     private val nativeRouter: NativeAuthFlowRouter,
     initialState: FinancialConnectionsSheetState
 ) : MavericksViewModel<FinancialConnectionsSheetState>(initialState) {
@@ -93,13 +101,13 @@ internal class FinancialConnectionsSheetViewModel @Inject constructor(
      *
      */
     private fun openAuthFlow(sync: SynchronizeSessionResponse) {
-        // stores manifest in state for future references.
-        val manifest = sync.manifest
-        val nativeAuthFlowEnabled = nativeRouter.nativeAuthFlowEnabled(sync.manifest)
-        viewModelScope.launch {
-            nativeRouter.logExposure(sync.manifest)
+        if (isBrowserAvailable().not()) {
+            logNoBrowserAvailableAndFinish()
+            return
         }
-        if (manifest.hostedAuthUrl == null) {
+        val nativeAuthFlowEnabled = nativeRouter.nativeAuthFlowEnabled(sync.manifest)
+        viewModelScope.launch { nativeRouter.logExposure(sync.manifest) }
+        if (sync.manifest.hostedAuthUrl == null) {
             withState {
                 finishWithResult(
                     state = it,
@@ -114,18 +122,34 @@ internal class FinancialConnectionsSheetViewModel @Inject constructor(
             }
             setState {
                 copy(
-                    manifest = manifest,
+                    manifest = sync.manifest,
                     webAuthFlowStatus = authFlowStatus,
                     viewEffect = if (nativeAuthFlowEnabled) {
                         OpenNativeAuthFlow(initialArgs.configuration, sync)
                     } else {
-                        OpenAuthFlowWithUrl(manifest.hostedAuthUrl)
+                        OpenAuthFlowWithUrl(sync.manifest.hostedAuthUrl)
                     }
                 )
             }
         }
     }
 
+    private fun logNoBrowserAvailableAndFinish() {
+        viewModelScope.launch {
+            val errorMessage = "[Android] No Web browser available to launch AuthFlow"
+            analyticsTracker.track(
+                Error(
+                    Pane.UNEXPECTED_ERROR,
+                    FinancialConnectionsClientError("AppInitializationError", errorMessage)
+                )
+            )
+            finishWithResult(
+                state = awaitState(),
+                result = Failed(UnsupportedOperationException(errorMessage))
+            )
+        }
+    }
+
     /**
      * Activity recreation changes the lifecycle order:
      *
@@ -167,6 +191,7 @@ internal class FinancialConnectionsSheetViewModel @Inject constructor(
                             state = state,
                             result = Canceled
                         )
+
                         AuthFlowStatus.INTERMEDIATE_DEEPLINK -> setState {
                             copy(
                                 webAuthFlowStatus = AuthFlowStatus.ON_EXTERNAL_ACTIVITY
@@ -195,6 +220,7 @@ internal class FinancialConnectionsSheetViewModel @Inject constructor(
                             state = state,
                             result = Canceled
                         )
+
                         AuthFlowStatus.INTERMEDIATE_DEEPLINK -> setState {
                             copy(
                                 webAuthFlowStatus = AuthFlowStatus.ON_EXTERNAL_ACTIVITY

financial-connections/src/main/java/com/stripe/android/financialconnections/analytics/AnalyticsMappers.kt

@@ -1,7 +1,8 @@
 package com.stripe.android.financialconnections.analytics
 
 import com.stripe.android.core.exception.StripeException
-import com.stripe.android.financialconnections.exception.FinancialConnectionsError
+import com.stripe.android.financialconnections.exception.FinancialConnectionsClientError
+import com.stripe.android.financialconnections.exception.FinancialConnectionsStripeError
 import com.stripe.android.financialconnections.exception.WebAuthFlowFailedException
 
 /**
@@ -15,7 +16,12 @@ internal fun Throwable.toEventParams(): Map<String, String?> = when (this) {
         "error_message" to message,
         "code" to null
     )
-    is FinancialConnectionsError -> mapOf(
+    is FinancialConnectionsClientError -> mapOf(
+        "error" to name,
+        "error_type" to name,
+        "error_message" to message,
+    )
+    is FinancialConnectionsStripeError -> mapOf(
         "error" to name,
         "error_type" to name,
         "error_message" to (stripeError?.message ?: message),

financial-connections/src/main/java/com/stripe/android/financialconnections/analytics/FinancialConnectionsEvent.kt

@@ -1,7 +1,7 @@
 package com.stripe.android.financialconnections.analytics
 
 import com.stripe.android.financialconnections.domain.ConfirmVerification.OTPError
-import com.stripe.android.financialconnections.exception.FinancialConnectionsError
+import com.stripe.android.financialconnections.exception.FinancialConnectionsStripeError
 import com.stripe.android.financialconnections.model.FinancialConnectionsSessionManifest.Pane
 import com.stripe.android.financialconnections.utils.filterNotNullValues
 
@@ -151,15 +151,6 @@ internal sealed class FinancialConnectionsEvent(
         ).filterNotNullValues()
     )
 
-    class ClickLinkAnotherAccount(
-        pane: Pane,
-    ) : FinancialConnectionsEvent(
-        name = "click.link_another_account",
-        mapOf(
-            "pane" to pane.value,
-        ).filterNotNullValues()
-    )
-
     class NetworkingNewConsumer(
         pane: Pane,
     ) : FinancialConnectionsEvent(
@@ -256,7 +247,7 @@ internal sealed class FinancialConnectionsEvent(
         exception: Throwable
     ) : FinancialConnectionsEvent(
         name = when (exception) {
-            is FinancialConnectionsError,
+            is FinancialConnectionsStripeError,
             is OTPError -> "error.expected"
             else -> "error.unexpected"
         },

financial-connections/src/main/java/com/stripe/android/financialconnections/domain/IsBrowserAvailable.kt

@@ -0,0 +1,21 @@
+package com.stripe.android.financialconnections.domain
+
+import android.app.Application
+import android.content.Intent
+import android.net.Uri
+import javax.inject.Inject
+
+/**
+ * Check if a browser is available on the device.
+ */
+internal class IsBrowserAvailable @Inject constructor(
+    private val context: Application,
+) {
+
+    operator fun invoke(): Boolean {
+        val url = "https://"
+        val webAddress = Uri.parse(url)
+        val intentWeb = Intent(Intent.ACTION_VIEW, webAddress)
+        return intentWeb.resolveActivity(context.packageManager) != null
+    }
+}

financial-connections/src/main/java/com/stripe/android/financialconnections/exception/AccountLoadError.kt

@@ -8,7 +8,7 @@ internal class AccountLoadError(
     val canRetry: Boolean,
     val institution: FinancialConnectionsInstitution,
     stripeException: StripeException
-) : FinancialConnectionsError(
+) : FinancialConnectionsStripeError(
     name = "AccountLoadError",
     stripeException = stripeException
 )

financial-connections/src/main/java/com/stripe/android/financialconnections/exception/AccountNoneEligibleForPaymentMethodError.kt

@@ -8,18 +8,7 @@ internal class AccountNoneEligibleForPaymentMethodError(
     val institution: FinancialConnectionsInstitution,
     val merchantName: String,
     stripeException: StripeException,
-) : FinancialConnectionsError(
+) : FinancialConnectionsStripeError(
     name = "AccountNoneEligibleForPaymentMethodError",
     stripeException = stripeException
 )
-
-internal abstract class FinancialConnectionsError(
-    val name: String,
-    stripeException: StripeException,
-) : StripeException(
-    stripeException.stripeError,
-    stripeException.requestId,
-    stripeException.statusCode,
-    stripeException.cause,
-    stripeException.message
-)

financial-connections/src/main/java/com/stripe/android/financialconnections/exception/AccountNumberRetrievalError.kt

@@ -7,7 +7,7 @@ internal class AccountNumberRetrievalError(
     val allowManualEntry: Boolean,
     val institution: FinancialConnectionsInstitution,
     stripeException: StripeException
-) : FinancialConnectionsError(
+) : FinancialConnectionsStripeError(
     name = "AccountNumberRetrievalError",
     stripeException = stripeException
 )

financial-connections/src/main/java/com/stripe/android/financialconnections/exception/FinancialConnectionsClientError.kt

@@ -0,0 +1,11 @@
+package com.stripe.android.financialconnections.exception
+
+import java.lang.Exception
+
+/**
+ * Base class for client errors that occur during the financial connections flow.
+ */
+internal class FinancialConnectionsClientError(
+    val name: String,
+    override val message: String
+) : Exception()

financial-connections/src/main/java/com/stripe/android/financialconnections/exception/FinancialConnectionsStripeError.kt

@@ -0,0 +1,17 @@
+package com.stripe.android.financialconnections.exception
+
+import com.stripe.android.core.exception.StripeException
+
+/**
+ * Base class for errors that occur during the financial connections flow.
+ */
+internal abstract class FinancialConnectionsStripeError(
+    val name: String,
+    stripeException: StripeException,
+) : StripeException(
+    stripeException.stripeError,
+    stripeException.requestId,
+    stripeException.statusCode,
+    stripeException.cause,
+    stripeException.message
+)

financial-connections/src/main/java/com/stripe/android/financialconnections/exception/InstitutionPlannedDowntimeError.kt

@@ -9,7 +9,7 @@ internal class InstitutionPlannedDowntimeError(
     val isToday: Boolean,
     val backUpAt: Long,
     stripeException: StripeException
-) : FinancialConnectionsError(
+) : FinancialConnectionsStripeError(
     name = "InstitutionPlannedDowntimeError",
     stripeException = stripeException,
 )

financial-connections/src/main/java/com/stripe/android/financialconnections/exception/InstitutionUnplannedDowntimeError.kt

@@ -7,7 +7,7 @@ internal class InstitutionUnplannedDowntimeError(
     val institution: FinancialConnectionsInstitution,
     val allowManualEntry: Boolean,
     stripeException: StripeException
-) : FinancialConnectionsError(
+) : FinancialConnectionsStripeError(
     name = "InstitutionUnplannedDowntimeError",
     stripeException = stripeException
 )