-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete basic integration CustomerSession from examples #9388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse output:
APK
|
samer-stripe
approved these changes
Oct 2, 2024
amk-stripe
added a commit
that referenced
this pull request
Oct 7, 2024
* Delete basic integration CustomerSession from examples * Delete unused import
amk-stripe
added a commit
that referenced
this pull request
Oct 7, 2024
* Delete basic integration CustomerSession from examples * Delete unused import
amk-stripe
added a commit
that referenced
this pull request
Oct 7, 2024
* Delete AddPaymentMethodActivity from examples * Fix indentation * Remove netbanking test * Delete basic integration CustomerSession from examples (#9388) * Delete basic integration CustomerSession from examples * Delete unused import * Delete tests
amk-stripe
added a commit
that referenced
this pull request
Nov 12, 2024
This reverts commit 836bc65.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Delete basic integration CustomerSession from examples
Ensured that this didn't leave any dead code behind by using the "analyze > inspect code" tool in Android Studio
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2405
Pre-work for deprecating basic integration is to remove our code samples that reference BI