-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete AddPaymentMethodActivity from examples #9389
Delete AddPaymentMethodActivity from examples #9389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a BI-specific test. Since we will be removing BI in a month-ish anyways, I think it's safe to delete this test. We have other tests for Fpx outside of BI, e.g. TestFpx
Diffuse output:
APK
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rationale for deleting this test is the same as for deleting the Fpx test: This is a BI-specific test. Since we will be removing BI in a month-ish anyways, it's safe to delete this test.
We don't have other tests for Netbanking, but we have 0 users: https://hubble.corp.stripe.com/queries/amk/0b2180e2
And since this entry point is deprecated + will be deleted soon + is not mentioned on docs.stripe.com anywhere, I think we are good to just leave this untested.
* Delete basic integration CustomerSession from examples * Delete unused import
6e620ae
to
0b127c3
Compare
This reverts commit 8f35fe0.
Summary
Delete AddPaymentMethodActivity from examples
Ensured that this didn't leave any dead code behind by using the "analyze > inspect code" tool in Android Studio
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2405
Pre-work for deprecating basic integration is to remove our code samples that reference BI