-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix requirement for phone number not being respected for AddressElement
#9577
Fix requirement for phone number not being respected for AddressElement
#9577
Conversation
Diffuse output:
APK
DEX
|
@@ -60,7 +60,7 @@ open class AddressElement( | |||
PhoneNumberController.createPhoneNumberController( | |||
initialValue = rawValuesMap[IdentifierSpec.Phone] ?: "", | |||
showOptionalLabel = addressType.phoneNumberState == PhoneNumberState.OPTIONAL, | |||
acceptAnyInput = true, | |||
acceptAnyInput = addressType.phoneNumberState != PhoneNumberState.REQUIRED, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't affect PaymentSheet
as it has separate fields for collecting phone numbers and is only required if collectPhone
is true in BillingDetailsCollectionConfiguration
. Collecting full billing details does not expose the phone number field as it does in the AddressElement
product.
stripe-ui-core/src/main/java/com/stripe/android/uicore/elements/AddressElement.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
43ad3ae
to
3b92d5b
Compare
Summary
Fix requirement for phone number not being respected for
AddressElement
.Motivation
Ensures
AddressElement
phone requirements are respected.Testing