Show promo badge in bank form #9734

tillh-stripe · 2024-12-03T22:20:14Z

Summary

This pull request adds the promo badge in the account details section of the bank form.

Motivation

Testing

Added tests
Modified tests
Manually verified

Screenshots

Before	After
before screenshot	after screenshot

Changelog

github-actions · 2024-12-03T22:26:29Z

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ -6 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -6 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0

APK

   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 28.4 KiB │ -4 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    271 B │ -1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ -1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 29.9 KiB │ -6 B │ 64.2 KiB │  0 B │ (total)

tillh-stripe · 2024-12-04T00:56:16Z

...c/main/java/com/stripe/android/paymentsheet/paymentdatacollection/ach/BankFormScreenState.kt

@@ -41,8 +50,14 @@ internal data class BankFormScreenState(
        val financialConnectionsSessionId: String?,
        val mandateText: ResolvableString,
        val isVerifyingWithMicrodeposits: Boolean,
+        val eligibleForIncentive: Boolean = false,


This is currently hard-coded to false, but will eventually be set in the bank auth flow.

carlosmuvi-stripe

looks great!

carlosmuvi-stripe · 2024-12-05T17:52:51Z

paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/PromoBadge.kt

+        if (context.isEnglishLanguage) {
+            "Get $text"
+        } else {
+            text
+        }


No action - I guess this is a backend limitation, but shouldn't we get complete text from backend?

We only get the formatted amount from the backend. That’s the way we intended it, since we need this in multiple places with different text (or none) around it.

carlosmuvi-stripe · 2024-12-05T17:53:38Z

paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/PromoBadge.kt

+private val Context.isEnglishLanguage: Boolean
+    get() {
+        val currentLocale: Locale = if (SDK_INT >= N) {
+            resources.configuration.locales[0]
+        } else {
+            @Suppress("DEPRECATION")
+            resources.configuration.locale
+        }
+
+        return currentLocale.language == Locale.ENGLISH.language
+    }


[nit] Likely useful on other scenarios, could be moved to a common module

I honestly don’t want to further encourage this pattern, so I’ll keep it here for now 😅

carlosmuvi-stripe · 2024-12-05T17:54:22Z

...tdatacollection.ach_AccountPreviewScreenshotTest_testWithIneligiblePromoBadge[DarkTheme].png

A test with a very long bank name would be great to ensure the badge is still visible and correctly placed

Fix layout issue with super-long bank name and validate with screenshot test.

* Show promo badge in bank form * Address code review feedback Fix layout issue with super-long bank name and validate with screenshot test.

* Initial camera implementation # Conflicts: # connect-example/src/main/java/com/stripe/android/connect/example/ui/features/payouts/PayoutsExampleActivity.kt # connect/src/main/java/com/stripe/android/connect/PayoutsView.kt # Conflicts: # connect/src/main/java/com/stripe/android/connect/PayoutsView.kt # connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewClient.kt # Conflicts: # connect-example/src/main/java/com/stripe/android/connect/example/ui/features/payouts/PayoutsExampleActivity.kt # connect/src/main/java/com/stripe/android/connect/EmbeddedComponentManager.kt # connect/src/main/java/com/stripe/android/connect/PayoutsView.kt * Update request code * Update example activity * Refactor permission, handle within manager * Fix leftover merge conflicts # Conflicts: # connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewContainer.kt * WIP * Fix merge * Fix build issues * fix activity * Fix suspend function * refactor with activity oncreate * Show promo badge in bank form (#9734) * Show promo badge in bank form * Address code review feedback Fix layout issue with super-long bank name and validate with screenshot test. * Add Embedded Appearance params to AppearanceBottomSheetDialogFragment (#9727) * Add Embedded Appearance params to AppearanceBottomSheetDialogFragment * [MOBILESDK-2480]update text style for bacs secondary button type (#9745) * update text style for bacs secondary button type * screenshots for screenshot tests * Apply suggestions from code review Capitalize comment and add period Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com> * crypto payment method (#9753) * Better handle process death for all confirmation flow cases in `DefaultConfirmationHandler` (#9754) * Fix lints, remove unneeded cancellation function * Add tests * Fix tests * Add/fix logging * Fix lint from log line * Fix main thread * Update connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewContainer.kt Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com> * Update connect/src/main/java/com/stripe/android/connect/EmbeddedComponentManager.kt Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com> * unsupported behavior to log warning * Fix docstrings * Update crashing behavior for camera permission request * Move functions around for clarity * Update tests * Update and fix tests * Fix detekt lints * Fix main activity * Remove unnecessary fragment, move logger out of constructor * Clean up lib restriction * Remove unnecessary unconfined test dispatcher * Update api * Lint fixes --------- Co-authored-by: Till Hellmund <tillh@stripe.com> Co-authored-by: tjclawson-stripe <163896025+tjclawson-stripe@users.noreply.github.com> Co-authored-by: Tian Zhao <tianzhao@stripe.com> Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com> Co-authored-by: ericzhang-stripe <94195995+ericzhang-stripe@users.noreply.github.com> Co-authored-by: Samer Alabi <141707240+samer-stripe@users.noreply.github.com> Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com>

tillh-stripe force-pushed the tillh/ibp-incentives-bank-form-badge branch from 9511890 to 2e443dd Compare December 3, 2024 22:25

tillh-stripe force-pushed the tillh/ibp-incentives-bank-form-badge branch 2 times, most recently from 6fa3485 to 2efdef9 Compare December 3, 2024 23:27

tillh-stripe commented Dec 4, 2024

View reviewed changes

tillh-stripe force-pushed the tillh/ibp-incentives-bank-form-badge branch from 2efdef9 to fa657c7 Compare December 4, 2024 04:02

Show promo badge in bank form

01500e5

tillh-stripe force-pushed the tillh/ibp-incentives-bank-form-badge branch from fa657c7 to 01500e5 Compare December 4, 2024 15:01

tillh-stripe requested a review from carlosmuvi-stripe December 4, 2024 19:40

tillh-stripe marked this pull request as ready for review December 4, 2024 19:40

tillh-stripe requested review from a team as code owners December 4, 2024 19:40

tillh-stripe requested a review from samer-stripe December 4, 2024 19:40

carlosmuvi-stripe reviewed Dec 5, 2024

View reviewed changes

tillh-stripe force-pushed the tillh/ibp-incentives-bank-form-badge branch from 4e35829 to b07a81e Compare December 5, 2024 20:29

Address code review feedback

99bd861

Fix layout issue with super-long bank name and validate with screenshot test.

tillh-stripe force-pushed the tillh/ibp-incentives-bank-form-badge branch from b07a81e to 99bd861 Compare December 5, 2024 20:51

tillh-stripe requested a review from carlosmuvi-stripe December 5, 2024 21:08

tillh-stripe enabled auto-merge (squash) December 5, 2024 21:08

carlosmuvi-stripe approved these changes Dec 5, 2024

View reviewed changes

tillh-stripe merged commit d0b46bc into master Dec 5, 2024
13 checks passed

tillh-stripe deleted the tillh/ibp-incentives-bank-form-badge branch December 5, 2024 21:11

simond-stripe pushed a commit that referenced this pull request Dec 6, 2024

Show promo badge in bank form (#9734)

48b43fe

* Show promo badge in bank form * Address code review feedback Fix layout issue with super-long bank name and validate with screenshot test.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show promo badge in bank form #9734

Show promo badge in bank form #9734

tillh-stripe commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024 •

edited

Loading

tillh-stripe Dec 4, 2024

carlosmuvi-stripe left a comment

carlosmuvi-stripe Dec 5, 2024

tillh-stripe Dec 5, 2024

carlosmuvi-stripe Dec 5, 2024

tillh-stripe Dec 5, 2024 •

edited

Loading

carlosmuvi-stripe Dec 5, 2024

Show promo badge in bank form #9734

Show promo badge in bank form #9734

Conversation

tillh-stripe commented Dec 3, 2024 • edited Loading

Summary

Motivation

Testing

Screenshots

Changelog

github-actions bot commented Dec 3, 2024 • edited Loading

tillh-stripe Dec 4, 2024

Choose a reason for hiding this comment

carlosmuvi-stripe left a comment

Choose a reason for hiding this comment

carlosmuvi-stripe Dec 5, 2024

Choose a reason for hiding this comment

tillh-stripe Dec 5, 2024

Choose a reason for hiding this comment

carlosmuvi-stripe Dec 5, 2024

Choose a reason for hiding this comment

tillh-stripe Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

carlosmuvi-stripe Dec 5, 2024

Choose a reason for hiding this comment

tillh-stripe commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024 •

edited

Loading

tillh-stripe Dec 5, 2024 •

edited

Loading