-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOBILESDK-2480]update text style for bacs secondary button type #9745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse output:
APK
|
amk-stripe
previously approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for doing this!
...rc/main/java/com/stripe/android/paymentsheet/paymentdatacollection/bacs/BacsMandateButton.kt
Outdated
Show resolved
Hide resolved
Looks like Bitrise failed on this.
|
tianzhao-stripe
changed the title
update text style for bacs secondary button type
[MOBILESDK-2480]update text style for bacs secondary button type
Dec 5, 2024
Capitalize comment and add period Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com>
amk-stripe
approved these changes
Dec 5, 2024
simond-stripe
pushed a commit
that referenced
this pull request
Dec 6, 2024
* update text style for bacs secondary button type * screenshots for screenshot tests * Apply suggestions from code review Capitalize comment and add period Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com>
simond-stripe
added a commit
that referenced
this pull request
Dec 12, 2024
* Initial camera implementation # Conflicts: # connect-example/src/main/java/com/stripe/android/connect/example/ui/features/payouts/PayoutsExampleActivity.kt # connect/src/main/java/com/stripe/android/connect/PayoutsView.kt # Conflicts: # connect/src/main/java/com/stripe/android/connect/PayoutsView.kt # connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewClient.kt # Conflicts: # connect-example/src/main/java/com/stripe/android/connect/example/ui/features/payouts/PayoutsExampleActivity.kt # connect/src/main/java/com/stripe/android/connect/EmbeddedComponentManager.kt # connect/src/main/java/com/stripe/android/connect/PayoutsView.kt * Update request code * Update example activity * Refactor permission, handle within manager * Fix leftover merge conflicts # Conflicts: # connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewContainer.kt * WIP * Fix merge * Fix build issues * fix activity * Fix suspend function * refactor with activity oncreate * Show promo badge in bank form (#9734) * Show promo badge in bank form * Address code review feedback Fix layout issue with super-long bank name and validate with screenshot test. * Add Embedded Appearance params to AppearanceBottomSheetDialogFragment (#9727) * Add Embedded Appearance params to AppearanceBottomSheetDialogFragment * [MOBILESDK-2480]update text style for bacs secondary button type (#9745) * update text style for bacs secondary button type * screenshots for screenshot tests * Apply suggestions from code review Capitalize comment and add period Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com> * crypto payment method (#9753) * Better handle process death for all confirmation flow cases in `DefaultConfirmationHandler` (#9754) * Fix lints, remove unneeded cancellation function * Add tests * Fix tests * Add/fix logging * Fix lint from log line * Fix main thread * Update connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewContainer.kt Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com> * Update connect/src/main/java/com/stripe/android/connect/EmbeddedComponentManager.kt Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com> * unsupported behavior to log warning * Fix docstrings * Update crashing behavior for camera permission request * Move functions around for clarity * Update tests * Update and fix tests * Fix detekt lints * Fix main activity * Remove unnecessary fragment, move logger out of constructor * Clean up lib restriction * Remove unnecessary unconfined test dispatcher * Update api * Lint fixes --------- Co-authored-by: Till Hellmund <tillh@stripe.com> Co-authored-by: tjclawson-stripe <163896025+tjclawson-stripe@users.noreply.github.com> Co-authored-by: Tian Zhao <tianzhao@stripe.com> Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com> Co-authored-by: ericzhang-stripe <94195995+ericzhang-stripe@users.noreply.github.com> Co-authored-by: Samer Alabi <141707240+samer-stripe@users.noreply.github.com> Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated BacsMandateButtonType.Secondary to read from system theming so the text formatting is the same as the rest of payment sheet
Motivation
The "modify details" button in the bacs mandate should look the same
https://jira.corp.stripe.com/browse/MOBILESDK-2480
Testing
Screenshots
Changelog
NA