Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOBILESDK-2480]update text style for bacs secondary button type #9745

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

tianzhao-stripe
Copy link
Contributor

@tianzhao-stripe tianzhao-stripe commented Dec 5, 2024

Summary

Updated BacsMandateButtonType.Secondary to read from system theming so the text formatting is the same as the rest of payment sheet

Motivation

The "modify details" button in the bacs mandate should look the same
https://jira.corp.stripe.com/browse/MOBILESDK-2480

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
Screenshot_20241204-170149 1000000021

Changelog

NA

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │   0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │   0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │   0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.3 KiB │ +15 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +15 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
    compressed    │  uncompressed   │                        
──────────┬───────┼──────────┬──────┤                        
 size     │ diff  │ size     │ diff │ path                   
──────────┼───────┼──────────┼──────┼────────────────────────
 28.5 KiB │ +12 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.3 KiB │  +2 B │ 62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │  +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼───────┼──────────┼──────┼────────────────────────
 54.9 KiB │ +15 B │  127 KiB │  0 B │ (total)

amk-stripe
amk-stripe previously approved these changes Dec 5, 2024
Copy link
Collaborator

@amk-stripe amk-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this!

@amk-stripe
Copy link
Collaborator

Looks like Bitrise failed on this.

  • instrumentation tests failed, but the failure looks irrelevant to this (probably a test flake)
  • screenshot tests failed, because we have some screenshots that need to be updated due to this change. You can update the screenshots by downloading them from the "artifacts" tab in the bitrise test run and then moving the new screenshots into your branch -- lmk if I can help with that

@tianzhao-stripe tianzhao-stripe changed the title update text style for bacs secondary button type [MOBILESDK-2480]update text style for bacs secondary button type Dec 5, 2024
Capitalize comment and add period

Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com>
@tianzhao-stripe tianzhao-stripe merged commit 947351b into master Dec 6, 2024
13 checks passed
@tianzhao-stripe tianzhao-stripe deleted the MOBILESDK-2480 branch December 6, 2024 00:24
simond-stripe pushed a commit that referenced this pull request Dec 6, 2024
* update text style for bacs secondary button type

* screenshots for screenshot tests

* Apply suggestions from code review

Capitalize comment and add period

Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com>
simond-stripe added a commit that referenced this pull request Dec 12, 2024
* Initial camera implementation

# Conflicts:
#	connect-example/src/main/java/com/stripe/android/connect/example/ui/features/payouts/PayoutsExampleActivity.kt
#	connect/src/main/java/com/stripe/android/connect/PayoutsView.kt

# Conflicts:
#	connect/src/main/java/com/stripe/android/connect/PayoutsView.kt
#	connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewClient.kt

# Conflicts:
#	connect-example/src/main/java/com/stripe/android/connect/example/ui/features/payouts/PayoutsExampleActivity.kt
#	connect/src/main/java/com/stripe/android/connect/EmbeddedComponentManager.kt
#	connect/src/main/java/com/stripe/android/connect/PayoutsView.kt

* Update request code

* Update example activity

* Refactor permission, handle within manager

* Fix leftover merge conflicts

# Conflicts:
#	connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewContainer.kt

* WIP

* Fix merge

* Fix build issues

* fix activity

* Fix suspend function

* refactor with activity oncreate

* Show promo badge in bank form (#9734)

* Show promo badge in bank form

* Address code review feedback

Fix layout issue with super-long bank name and validate with screenshot test.

* Add Embedded Appearance params to AppearanceBottomSheetDialogFragment (#9727)

* Add Embedded Appearance params to AppearanceBottomSheetDialogFragment

* [MOBILESDK-2480]update text style for bacs secondary button type (#9745)

* update text style for bacs secondary button type

* screenshots for screenshot tests

* Apply suggestions from code review

Capitalize comment and add period

Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com>

* crypto payment method (#9753)

* Better handle process death for all confirmation flow cases in `DefaultConfirmationHandler` (#9754)

* Fix lints, remove unneeded cancellation function

* Add tests

* Fix tests

* Add/fix logging

* Fix lint from log line

* Fix main thread

* Update connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewContainer.kt

Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com>

* Update connect/src/main/java/com/stripe/android/connect/EmbeddedComponentManager.kt

Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com>

* unsupported behavior to log warning

* Fix docstrings

* Update crashing behavior for camera permission request

* Move functions around for clarity

* Update tests

* Update and fix tests

* Fix detekt lints

* Fix main activity

* Remove unnecessary fragment, move logger out of constructor

* Clean up lib restriction

* Remove unnecessary unconfined test dispatcher

* Update api

* Lint fixes

---------

Co-authored-by: Till Hellmund <tillh@stripe.com>
Co-authored-by: tjclawson-stripe <163896025+tjclawson-stripe@users.noreply.github.com>
Co-authored-by: Tian Zhao <tianzhao@stripe.com>
Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com>
Co-authored-by: ericzhang-stripe <94195995+ericzhang-stripe@users.noreply.github.com>
Co-authored-by: Samer Alabi <141707240+samer-stripe@users.noreply.github.com>
Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants