Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace references to identity cards with identity document (fixes #9829) #9829

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

kentwilliams-stripe
Copy link
Contributor

@kentwilliams-stripe kentwilliams-stripe commented Dec 24, 2024

Summary

Instead of referring to an ID as "Identity Card" we use the term "Identity Document" to avoid confusion when only one type non-card identity is permitted.

Also remove unused definitions of stripe_back_of_id_document and stripe_front_of_id_document messages.

Motivation

Addresses #8511

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
CleanShot 2024-12-24 at 14 35 47@2x image

Changelog

  • [Changed] all references to "Identity Card" to say "Identity Document"

Copy link
Contributor

github-actions bot commented Dec 24, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │     2 MiB │     2 MiB │   -5 B │   4.1 MiB │   4.1 MiB │    0 B 
     arsc │     1 MiB │     1 MiB │ +184 B │     1 MiB │     1 MiB │ +184 B 
 manifest │   2.3 KiB │   2.3 KiB │    0 B │     8 KiB │     8 KiB │    0 B 
      res │ 301.8 KiB │ 301.8 KiB │    0 B │ 455.5 KiB │ 455.5 KiB │    0 B 
   native │   6.2 MiB │   6.2 MiB │    0 B │  15.8 MiB │  15.8 MiB │    0 B 
    asset │   7.2 KiB │   7.2 KiB │   -1 B │   6.9 KiB │   6.9 KiB │   -1 B 
    other │  90.2 KiB │  90.2 KiB │    0 B │ 170.3 KiB │ 170.3 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │   9.6 MiB │   9.6 MiB │ +178 B │  21.5 MiB │  21.5 MiB │ +183 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19971 │ 19971 │ 0 (+1 -1) 
   types │  6191 │  6191 │ 0 (+0 -0) 
 classes │  4982 │  4982 │ 0 (+0 -0) 
 methods │ 29771 │ 29771 │ 0 (+0 -0) 
  fields │ 17541 │ 17541 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff      
─────────┼──────┼──────┼───────────
 configs │  164 │  164 │ 0         
 entries │ 3622 │ 3622 │ 0 (+2 -2)
APK
    compressed     │   uncompressed    │                               
──────────┬────────┼──────────┬────────┤                               
 size     │ diff   │ size     │ diff   │ path                          
──────────┼────────┼──────────┼────────┼───────────────────────────────
    1 MiB │ +184 B │    1 MiB │ +184 B │ ∆ resources.arsc              
    2 MiB │   -5 B │  4.1 MiB │    0 B │ ∆ classes.dex                 
  1.2 KiB │   +2 B │  1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA           
  6.3 KiB │   -1 B │  6.2 KiB │   -1 B │ ∆ assets/dexopt/baseline.prof 
 28.5 KiB │   -1 B │ 62.9 KiB │    0 B │ ∆ META-INF/CERT.SF            
 25.3 KiB │   -1 B │ 62.8 KiB │    0 B │ ∆ META-INF/MANIFEST.MF        
──────────┼────────┼──────────┼────────┼───────────────────────────────
  3.1 MiB │ +178 B │  5.3 MiB │ +183 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   19971 │ 19971 │ 0 (+1 -1) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"3387721","r8-mode":"full","version":"8.7.14"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"ef81921","r8-mode":"full","version":"8.7.14"}
ARSC
ENTRIES:

   old  │ new  │ diff      
  ──────┼──────┼───────────
   3622 │ 3622 │ 0 (+2 -2) 
  + string/stripe_back_of_id_document
  + string/stripe_front_of_id_document
  
  - string/stripe_back_of_id
  - string/stripe_front_of_id

@kentwilliams-stripe kentwilliams-stripe changed the title Replace references to identity cards with identity document Replace references to identity cards with identity document (fixes #9829) Dec 25, 2024
@kentwilliams-stripe kentwilliams-stripe merged commit a23d0a6 into master Jan 7, 2025
13 checks passed
@kentwilliams-stripe kentwilliams-stripe deleted the replace-references-to-identity-card branch January 7, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants