-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Wrong title "Front of identity card" #8511
Comments
@ccen-stripe I've seen that the problem seems to be solved on iOS but not yet on Android. |
@ccen-stripe In the web version it explicitly says "driver’s licencse" if that is the only document that’s accepted. It would be perfect if the SDK would also do it like this:
|
I've seen that with this commit in the PR these new translations were added: <string name="stripe_front_of_id_document">Front of identity document</string>
<string name="stripe_back_of_id_document">Back of identity document</string> but they are not used in the code yet. |
…of identity card" See stripe#8511
Would be great to have that one fixed soon! |
Would be awesome if this gets fixed! |
Hi! Working on this now in #9829 |
Summary
We only accept driving licences but in the interface users get confused because the headers are "Front of identity card" and "Back of identity card".
In German this translates to "Vorderseite des Personalausweises" which is not a driving license.
See also:
Version
The problem occurs with
stripe-android
v20.44.0Details
We currently only accept driver's licences by defining
options.document.allowed_types = ["driving_license"]
when using the APIAvailable options are:
driving_license
... Drivers license document type.id_card
... ID card document type.passport
... Passport document type.The optimal solution would be that the title corresponds exactly with
options.document.allowed_types
. This is how the web version already does it.Example:
options.document.allowed_types
["driving_license"]
<string name="stripe_front_of_dl">Front of driver\'s license</string>
["id_card"]
<string name="stripe_front_of_id">Front of identity card</string>
["passport"]
<string name="stripe_passport">Passport</string>
["driving_license", "id_card", "passport"]
<string name="stripe_front_of_id_document">Front of identity document</string>
But in the interface the title is always "Front of identity card" (
stripe_front_of_id
)The text is
stripe_position_id_front
: "Position your identity card in the centre of the frame".In the code you only use
stripe_front_of_id
here.The strings
stripe_front_of_dl
"Front of driving licence" and "Back of driving licence" (stripe_back_of_dl
) are defined but not used in the code.On the first screen you use:
"Get ready to scan your photo ID" which is defined here.
The text was updated successfully, but these errors were encountered: