Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wrong title "Front of identity card" #8511

Open
googol7 opened this issue May 22, 2024 · 6 comments
Open

[BUG] Wrong title "Front of identity card" #8511

googol7 opened this issue May 22, 2024 · 6 comments
Assignees

Comments

@googol7
Copy link

googol7 commented May 22, 2024

Summary

We only accept driving licences but in the interface users get confused because the headers are "Front of identity card" and "Back of identity card".

In German this translates to "Vorderseite des Personalausweises" which is not a driving license.

See also:

Version

The problem occurs with stripe-android v20.44.0

Details

We currently only accept driver's licences by defining options.document.allowed_types = ["driving_license"] when using the API

Available options are:

  • driving_license ... Drivers license document type.
  • id_card ... ID card document type.
  • passport ... Passport document type.

The optimal solution would be that the title corresponds exactly with options.document.allowed_types. This is how the web version already does it.

Example:

options.document.allowed_types string used
["driving_license"] <string name="stripe_front_of_dl">Front of driver\'s license</string>
["id_card"] <string name="stripe_front_of_id">Front of identity card</string>
["passport"] <string name="stripe_passport">Passport</string>
["driving_license", "id_card", "passport"] <string name="stripe_front_of_id_document">Front of identity document</string>

But in the interface the title is always "Front of identity card" (stripe_front_of_id)

The text is stripe_position_id_front: "Position your identity card in the centre of the frame".

In the code you only use stripe_front_of_id here.

The strings stripe_front_of_dl "Front of driving licence" and "Back of driving licence" (stripe_back_of_dl) are defined but not used in the code.

Android Native - English 2


On the first screen you use:
"Get ready to scan your photo ID" which is defined here.

Android Native - English 1

@googol7
Copy link
Author

googol7 commented Jul 8, 2024

@ccen-stripe I've seen that the problem seems to be solved on iOS but not yet on Android.

@googol7
Copy link
Author

googol7 commented Jul 22, 2024

@ccen-stripe In the web version it explicitly says "driver’s licencse" if that is the only document that’s accepted. It would be perfect if the SDK would also do it like this:

  1. Get ready to scan your driver's license
    Grab your driver's license
  2. Front of driver's license
  3. Flip your ID over
    Get ready to scan the back of your ID
  4. Back of driver's license

0
1
2
3
4

@googol7
Copy link
Author

googol7 commented Sep 4, 2024

I've seen that with this commit in the PR

these new translations were added:

<string name="stripe_front_of_id_document">Front of identity document</string>
<string name="stripe_back_of_id_document">Back of identity document</string>

but they are not used in the code yet.

@dbartenstein
Copy link

Would be great to have that one fixed soon!

@LucaB01
Copy link

LucaB01 commented Sep 19, 2024

Would be awesome if this gets fixed!

@kentwilliams-stripe
Copy link
Contributor

Hi! Working on this now in #9829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants