-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support v2 openapi #1298
support v2 openapi #1298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small questions
return nil | ||
} | ||
|
||
func constructedNestedStringParams(params map[string]interface{}, paramKeys []string, stringVal *string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to DRY these with generics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i spent a little bit of the effort to make it generic but the generic typing made it too complicated and i wanted to get the v2 commands working first. i can create a followup PR to create a generic parsing method
Reviewers
r?
cc @stripe/developer-products
Summary
main help text
stripe v2 help
run v2 command - GET (redacted)
run v2 command - POST (redacted)
run v2 command without secret key
v1 commands remains working