Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single_use string constant #1084

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Fix single_use string constant #1084

merged 1 commit into from
Jan 16, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Replaces #988 which has become stale and adds a test.

@ob-stripe ob-stripe requested a review from remi-stripe January 3, 2018 14:11
remi-stripe
remi-stripe approved these changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ob-stripe ob-stripe assigned ob-stripe and unassigned remi-stripe Jan 3, 2018
@remi-stripe remi-stripe mentioned this pull request Jan 3, 2018
Closed
@remi-stripe remi-stripe mentioned this pull request Jan 15, 2018
Closed
@ob-stripe ob-stripe merged commit 32a803c into master Jan 16, 2018
@ob-stripe ob-stripe deleted the ob-fix-single-use branch January 16, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @remi-stripe