Changed single-use to single_use #988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anelder-stripe assigning this one to you, looks like this one should be merged in though I'm surprised we didn't have test errors before this fix. |
|
r? @brandur-stripe @fred-stripe |
|
@Kaegun Sorry for the delays on this one. We ship a lot of fixes today to the library. Would you mind rebasing your branch so that we can get it other the finish line? Can you also add a test so that it confirms the change does work as expected? |
|
Closing this one as @ob-stripe pushed a new one in #1084 |
|
Thank remi, can I delete the branch? |
|
@Kaegun you can as it's been fixed and merged already! |
|
Done. Thanks for fixing it! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there's a typo in the Constants for Usage.