-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stripe-dotnet v20.0 #1293
stripe-dotnet v20.0 #1293
Conversation
6f52c2b
to
e246aa4
Compare
bd39334
to
79e5289
Compare
ed26725
to
e9da922
Compare
f082187
to
c6704cd
Compare
Also made a few changes to some resources to match the API naming and added support for AddressJapan on the Account resource.
c6704cd
to
e9fd90d
Compare
Okay, I've removed the WIP tag and rebased on master. r? @remi-stripe for another set of 👀 before I pull this in |
Pulling this in 🎉 |
Released as 20.0.0. |
Why was ISupportMetadata removed and nothing equivalent put in it's place? I have extension methods that use that interface in order to return strongly typed values from the meta data and now I have to write each extension method for each object separately. That's a giant pain in the ass I didn't need. |
@buvinghausen We removed it because it no longer served a purpose internally and we hadn't considered that it might be directly used by users. I don't see a problem with adding it back, though we'd rename it |
@ob-stripe I'm totally cool with an IHasMetadata replacement.... |
This PR will be used for ongoing work on the library to merge multiple PRs introducing large breaking changes to the library
Done:
(❗️= breaking changes)
INestedOptions
to properly use the parent property's JSON name (Rewrite parameter encoding logic #1276)SourceTransactionCanceled
event type (Rename event to match type name and add a related one. #1282)DateTime
s directly in the encoder ( HandleDateTime
s directly in the encoder #1283)StripeDeleted
and addDeleted
to relevant resources instead (Remove StripeDeleted entirely. #1284)Stripe
prefix (Remove Stripe prefix on all API classes #1252)InvoiceService
andRefundService
#1287, Fix FileUploadService #1288, BalanceTransactionService #1291)DateFilter
toDateRangeOptions
(Convert all options to have one class per level in the JSON params #1301)LiveMode
toLivemode
(Rename LiveMode to Livemode #1303)BasicService
for all services (Move all services to BasicService #1305)InvoiceItem
resource and keepInvoiceLineItem
to describe a line item on an invoice (Add support for InvoiceItem separate from InvoiceLineItem #1315)DateTime
s (Automatically convert Unix timestamps to DateTimes #1316)PaymentIntentSourceAction
(Use an interface for PaymentIntentSourceAction #1329)long
s instead ofint
s (Uselong
s instead ofint
s #1331)UsageRecord
methods to take a subscription item id (Usage record methods now take the subscription item id as a parameter #1340)SourceTokenOrExistingSourceId
toSourceId
(Rename SourceTokenOrExistingSourceId to SourceId #1337)charge.expired
(Add support for charge.expired #1345)Fixes #1164 (via #1283).
Fixes #1260 (via #1269).
Fixes #1281 (via #1282).
Fixes #1330 (via #1331).
Fixes #1344 (via #1345).
We decided not to change how object expansion work for now. The current behaviour is more verbose but is clearer for the developers using the library so we will keep the approach of having 2 properties (a string ResourceId and the object Resource with the ResourceInternal that does the right handling).