Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stripe-dotnet v20.0 #1293

Merged
merged 36 commits into from
Oct 22, 2018
Merged

stripe-dotnet v20.0 #1293

merged 36 commits into from
Oct 22, 2018

Conversation

ob-stripe
Copy link
Contributor

@ob-stripe ob-stripe commented Sep 21, 2018

This PR will be used for ongoing work on the library to merge multiple PRs introducing large breaking changes to the library

Done:

(❗️= breaking changes)

Fixes #1164 (via #1283).
Fixes #1260 (via #1269).
Fixes #1281 (via #1282).
Fixes #1330 (via #1331).
Fixes #1344 (via #1345).

We decided not to change how object expansion work for now. The current behaviour is more verbose but is clearer for the developers using the library so we will keep the approach of having 2 properties (a string ResourceId and the object Resource with the ResourceInternal that does the right handling).

@ob-stripe ob-stripe changed the title Integration next major version [WIP] Next major version Sep 21, 2018
@ob-stripe ob-stripe force-pushed the integration-next-major-version branch 4 times, most recently from 6f52c2b to e246aa4 Compare September 26, 2018 12:09
@ob-stripe ob-stripe force-pushed the integration-next-major-version branch 5 times, most recently from bd39334 to 79e5289 Compare October 4, 2018 15:32
@ob-stripe ob-stripe force-pushed the integration-next-major-version branch 4 times, most recently from ed26725 to e9da922 Compare October 9, 2018 12:23
@ob-stripe ob-stripe changed the title [WIP] Next major version stripe-dotnet v20.0 Oct 22, 2018
@ob-stripe ob-stripe force-pushed the integration-next-major-version branch from f082187 to c6704cd Compare October 22, 2018 15:59
@ob-stripe ob-stripe force-pushed the integration-next-major-version branch from c6704cd to e9fd90d Compare October 22, 2018 16:02
@ob-stripe
Copy link
Contributor Author

Okay, I've removed the WIP tag and rebased on master.

r? @remi-stripe for another set of 👀 before I pull this in

@ob-stripe
Copy link
Contributor Author

Pulling this in 🎉

@ob-stripe ob-stripe merged commit 28ac21d into master Oct 22, 2018
@ob-stripe
Copy link
Contributor Author

Released as 20.0.0.

@ob-stripe ob-stripe deleted the integration-next-major-version branch October 22, 2018 20:08
@buvinghausen
Copy link

Why was ISupportMetadata removed and nothing equivalent put in it's place? I have extension methods that use that interface in order to return strongly typed values from the meta data and now I have to write each extension method for each object separately. That's a giant pain in the ass I didn't need.

@ob-stripe
Copy link
Contributor Author

@buvinghausen We removed it because it no longer served a purpose internally and we hadn't considered that it might be directly used by users. I don't see a problem with adding it back, though we'd rename it IHasMetadata to be consistent with the new IHasId and IHasObject interfaces.

@buvinghausen
Copy link

@ob-stripe I'm totally cool with an IHasMetadata replacement....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment