Ensure all properties are on resources #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
changed the base branch from
master
to
integration-next-major-version
|
Looks much better! I wonder if we could write a wholesome test to ensure that fields are declared in alphabetical order (though probably difficult with |
|
Yeah I think lately I've rushed too many PRs and did not pay enough attention to the fields name and I also made a few mistakes so I'm going to start being more thorough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a pass using the OpenAPI spec + the Docs to ensure that all resources have the right list of properties. This meant adding multiple type-specific classes for Sources too.
Also renamed a few properties to match the API better such as
ExpirationMonth=>ExpMonth.r? @ob-stripe
cc @stripe/api-libraries