Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple Pay currency code documentation #828

Closed
toemat opened this issue Nov 3, 2017 · 1 comment · Fixed by #829
Closed

Apple Pay currency code documentation #828

toemat opened this issue Nov 3, 2017 · 1 comment · Fixed by #829

Comments

@toemat
Copy link

toemat commented Nov 3, 2017

Summary

PKPaymentAuthorizationViewController:paymentRequest returns nil when currencyCode is "usd" but works correctly for "USD". However, the documentation at https://stripe.com/docs/mobile/ios/custom#apple-pay specifies "usd".

The lowercase "usd" has worked in the past... Does the documentation need to be updated?

Code to reproduce

let paymentRequest = Stripe.paymentRequest(withMerchantIdentifier: merchantIdentifier, country: "US", currency: "usd")
...
let paymentAuthorizationViewController = PKPaymentAuthorizationViewController(paymentRequest: paymentRequest)

iOS version

11.0.1

Installation method

Cocoapods

SDK version

11.4.0

Other information

Noticed after updating from Stripe 10.*
@bdorfman-stripe
Copy link
Contributor

Hmm, possibly Apple's implementation of PKPaymentRequest or PKPaymentAuthorizationViewController has silently changed in iOS11 to require capitalized currency codes. Thanks for flagging we'll investigate either updating our docs or auto-capitalizing the strings for you.

@bdorfman-stripe bdorfman-stripe mentioned this issue Nov 3, 2017
Merged
mludowise-stripe pushed a commit that referenced this issue Mar 24, 2022
@vardges-stripe
Adds Connections soft linking interface (#828)
a8d4384 
* Adds connections sdk soft linking

* Fix version

* iOS12 availablility

* Add unit test

* localized strings fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Capitalize currency and country codes automatically stripe/stripe-ios
2 participants
@toemat @bdorfman-stripe