Capitalize currency and country codes automatically #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Payment context already force-capitalizes the currency code before attempting to create a PKPaymentAuthorizationViewController but this other helper method does not. iOS now returns nil for PKPaymentAuthorizationViewController if the request you create it with has a lowercase currency code so capitalize it automatically for people.
davidme-stripe
pushed a commit
that referenced
this pull request
Mar 7, 2022
Regenerated API models using swagger codegen. * Removes welcome screen * Adds timeEstimate and privacyPolicy to consent screen model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payment context already force-capitalizes the currency code before attempting to create a PKPaymentAuthorizationViewController but this other helper method does not. iOS now returns nil for PKPaymentAuthorizationViewController if the request you create it with has a lowercase currency code so capitalize it automatically for people.
Fixes #828 (will also update our examples in docs to have "USD" instead so that we are showing the correct thing, even though we will auto fix it for people).