[WIP] Fix strong reference cycles for STPRedirectContext, Improve tests #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeydong-stripe
force-pushed
the
joey/fixRedirectContextReference
branch
from
ab7a06f to
534ba28
Compare
joeydong-stripe
force-pushed
the
joey/fixRedirectContextReference
branch
from
12d38cc to
d20a2b9
Compare
| object:nil]; | ||
| [[STPURLCallbackHandler shared] registerListener:self | ||
| forURL:self.source.redirect.returnURL]; | ||
| [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(handleApplicationWillEnterForegroundNotification) name:UIApplicationWillEnterForegroundNotification object:nil]; |
There was a problem hiding this comment.
Why did you go through and remove the line breaks from like, every method call in all these files? I find it much harder to read like this.
| @@ -32,7 +32,7 @@ + (BOOL)handleStripeURLCallbackWithURL:(NSURL *)url FAUXPAS_IGNORED_ON_LINE(Unus | |||
|
|
|||
| @interface STPURLCallback : NSObject | |||
| @property (nonatomic) NSURLComponents *urlComponents; | |||
| @property (nonatomic) id<STPURLCallbackListener> listener; | |||
| @property (nonatomic, weak) id<STPURLCallbackListener> listener; | |||
There was a problem hiding this comment.
Is it potentially actually better to just leave this as it was and let the context retain itself for the duration of the redirect or until a cancel occurs? Or do you think that behavior is too unexpected.
|
Note: The retain cycle issues have been fixed on their own in #846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing test failures found in: #802
Summary
I think the
STPRedirectContextwas failing tests quietly in our previousXcode 8, iOS 10.xtesting but shows up when we enable the other Xcode / iOS versions.The first problem is some of the tests were intended to never call the
unsubscribeFromUrlAndForegroundNotifications. In particular, because theSTPURLCallbackHandlerheld a strong reference, theSTPRedirectContext<STPURLCallbackListener>ended up staying alive between tests leading to unexpected results.The second problem is the
startRedirectFlowFromViewControllerwas implicitly holding a strong reference to itself in its completion block. Reproducing this is similar to the first problem, either put a breakpoint indeallocand make sure it's called after every test, or send a valid url scheme to theSTPURLCallbackHandlerand see if any listener picks up.Finally, we needed to adjust the test cases so that they're compatible with all tested iOS versions
I took a broader stroke in the second commit because I was often getting lost/confused when trying to understand the implementation of
STPRedirectContext. I think some key method renaming is sufficient to solve that but definitely want to avoid introducing new bugs.The tests are still really tricky to maintain but the implementation itself is good so a refactoring just to simplify tests is probably a bad idea right now.
TODO: Update documentation, add
CHANGELOGandMIGRATINGentry to warn about holding a strong reference toSTPRedirectContextwhich was not needed before