Fix an STPURLCallbackListener retain cycle. #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a bug where STPURLCallbackListener retained its listeners, which meant that STPRedirectContext had a retain cycle and would not deallocate while it was actively listening for callbacks. Fixing this is in some ways a breaking API change. This commit fixes the bug, and also updates the docs to explicitly mention that you need to retain the instances you make. It also replaces referencing to STPAPIClient source polling (which is deprecated) and instead links to the sources best practices doc.
bg-stripe
approved these changes
Dec 11, 2017
CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| ## 12.0.0 2017-12-XX | |||
| * `STPRedirectContext` will no longer retain itself for the duration of the redirect, you must explicitly maintain a reference to it yourself. If you | |||
There was a problem hiding this comment.
Oh weird. I typed more stuff locally into Atom and it seems to not have saved the file before I comitted -_- Will fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a bug where STPURLCallbackListener retained its listeners, which meant that STPRedirectContext had a retain cycle and would not deallocate while it was actively listening for callbacks. Fixing this is in some ways a breaking API change.
This commit fixes the bug, and also updates the docs to explicitly mention that you need to retain the instances you make.
It also replaces referencing to STPAPIClient source polling (which is deprecated) and instead links to the sources best practices doc.